Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(all): bump to node 20.17 #4267

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions .github/workflows/metrics.yml
Original file line number Diff line number Diff line change
Expand Up @@ -10,12 +10,12 @@ jobs:
runs-on: ubuntu-latest
steps:
- name: Git checkout
uses: actions/checkout@v2
uses: actions/checkout@v4

- name: Node 18.x
uses: actions/setup-node@v2
- name: Node 20.x
uses: actions/setup-node@v4
with:
node-version: 18.x
node-version: 20.x

- name: Check dead code on app
working-directory: ./app
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/release.yml
Original file line number Diff line number Diff line change
Expand Up @@ -10,10 +10,10 @@ jobs:
runs-on: ubuntu-latest
strategy:
matrix:
node-version: [18.x]
node-version: [20.x]
steps:
- name: Checkout repository
uses: actions/checkout@v2
uses: actions/checkout@v4
with:
fetch-depth: 0
persist-credentials: false
Expand Down
6 changes: 3 additions & 3 deletions .github/workflows/run-tests-api-pr.yml
Original file line number Diff line number Diff line change
Expand Up @@ -25,11 +25,11 @@ jobs:
with:
ref: ${{ inputs.branch_name }}

- name: Node 18.x
- name: Node 20.x
if: steps.changes.outputs.src == 'true'
uses: actions/setup-node@v4
with:
node-version: 18.x
node-version: 20.x

- name: Start MongoDB 7.0
if: steps.changes.outputs.src == 'true'
Expand All @@ -48,7 +48,7 @@ jobs:
admin/node_modules
packages/ds/node_modules
packages/lib/node_modules
key: ${{ runner.os }}-nodemodules-${{ hashFiles('**/package-lock.json') }}
key: ${{ runner.os }}-nodemodules-${{ hashFiles('**/package-lock.json', '.nvmrc') }}
restore-keys: |
${{ runner.os }}-nodemodules-

Expand Down
8 changes: 4 additions & 4 deletions .github/workflows/run-tests-api-v2.yml
Original file line number Diff line number Diff line change
Expand Up @@ -23,10 +23,10 @@ jobs:
with:
ref: ${{ inputs.branch_name }}

- name: Node 18.x
- name: Node 20.x
uses: actions/setup-node@v4
with:
node-version: 18.x
node-version: 20.x

- uses: actions/cache@v4
id: cache-npm
Expand All @@ -39,7 +39,7 @@ jobs:
admin/node_modules
packages/ds/node_modules
packages/lib/node_modules
key: ${{ runner.os }}-nodemodules-${{ hashFiles('**/package-lock.json') }}
key: ${{ runner.os }}-nodemodules-${{ hashFiles('**/package-lock.json', '.nvmrc') }}
restore-keys: |
${{ runner.os }}-nodemodules-

Expand All @@ -51,6 +51,6 @@ jobs:
working-directory: packages/lib
run: npm run build

- name: Run tests
- name: Run tests
working-directory: apiv2
run: npm test
6 changes: 3 additions & 3 deletions .github/workflows/run-tests-api.yml
Original file line number Diff line number Diff line change
Expand Up @@ -23,10 +23,10 @@ jobs:
with:
ref: ${{ inputs.branch_name }}

- name: Node 18.x
- name: Node 20.x
uses: actions/setup-node@v4
with:
node-version: 18.x
node-version: 20.x

- name: Start MongoDB 7.0
uses: supercharge/[email protected]
Expand All @@ -44,7 +44,7 @@ jobs:
admin/node_modules
packages/ds/node_modules
packages/lib/node_modules
key: ${{ runner.os }}-nodemodules-${{ hashFiles('**/package-lock.json') }}
key: ${{ runner.os }}-nodemodules-${{ hashFiles('**/package-lock.json', '.nvmrc') }}
restore-keys: |
${{ runner.os }}-nodemodules-

Expand Down
6 changes: 3 additions & 3 deletions .github/workflows/run-tests-front.yml
Original file line number Diff line number Diff line change
Expand Up @@ -23,10 +23,10 @@ jobs:
with:
ref: ${{ inputs.branch_name }}

- name: Node 18.x
- name: Node 20.x
uses: actions/setup-node@v4
with:
node-version: 18.x
node-version: 20.x

- uses: actions/cache@v4
id: cache-npm
Expand All @@ -39,7 +39,7 @@ jobs:
admin/node_modules
packages/ds/node_modules
packages/lib/node_modules
key: ${{ runner.os }}-nodemodules-${{ hashFiles('**/package-lock.json') }}
key: ${{ runner.os }}-nodemodules-${{ hashFiles('**/package-lock.json', '.nvmrc') }}
restore-keys: |
${{ runner.os }}-nodemodules-

Expand Down
6 changes: 3 additions & 3 deletions .github/workflows/run-tests-lib.yml
Original file line number Diff line number Diff line change
Expand Up @@ -23,10 +23,10 @@ jobs:
with:
ref: ${{ inputs.branch_name }}

- name: Node 18.x
- name: Node 20.x
uses: actions/setup-node@v4
with:
node-version: 18.x
node-version: 20.x

- uses: actions/cache@v4
id: cache-npm
Expand All @@ -39,7 +39,7 @@ jobs:
admin/node_modules
packages/ds/node_modules
packages/lib/node_modules
key: ${{ runner.os }}-nodemodules-${{ hashFiles('**/package-lock.json') }}
key: ${{ runner.os }}-nodemodules-${{ hashFiles('**/package-lock.json', '.nvmrc') }}
restore-keys: |
${{ runner.os }}-nodemodules-

Expand Down
2 changes: 1 addition & 1 deletion .nvmrc
Original file line number Diff line number Diff line change
@@ -1 +1 @@
18.20
20.17
2 changes: 1 addition & 1 deletion admin/.nvmrc
Original file line number Diff line number Diff line change
@@ -1 +1 @@
18.20
20.17
2 changes: 1 addition & 1 deletion admin/Dockerfile
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
FROM node:18.20-alpine AS base
FROM node:20.17-alpine AS base

FROM base AS builder
# Check https://github.com/nodejs/docker-node/tree/b4117f9333da4138b03a546ec926ef50a31506c3#nodealpine to understand why libc6-compat might be needed.
Expand Down
4 changes: 2 additions & 2 deletions admin/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -87,8 +87,8 @@
"vite": "^5.4.0"
},
"engines": {
"node": "^18.20",
"npm": "^10.5",
"node": "^20.17",
"npm": "^10.8",
"yarn": "🍎 This project uses NPM, please do not use YARN. 🍎"
},
"optionalDependencies": {
Expand Down
2 changes: 1 addition & 1 deletion api/.nvmrc
Original file line number Diff line number Diff line change
@@ -1 +1 @@
18.20
20.17
2 changes: 1 addition & 1 deletion api/Dockerfile
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
# * https://turbo.build/repo/docs/handbook/deploying-with-docker
FROM node:18.20-alpine AS base
FROM node:20.17-alpine AS base

FROM base AS builder
# Check https://github.com/nodejs/docker-node/tree/b4117f9333da4138b03a546ec926ef50a31506c3#nodealpine to understand why libc6-compat might be needed.
Expand Down
4 changes: 2 additions & 2 deletions api/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -4,8 +4,8 @@
"description": "",
"main": "index.js",
"engines": {
"node": "^18.20",
"npm": "^10.5",
"node": "^20.17",
"npm": "^10.8",
"yarn": "🍎 This project uses NPM, please do not use YARN. 🍎"
},
"scripts": {
Expand Down
1 change: 1 addition & 0 deletions apiv2/.nvmrc
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
20.17
4 changes: 2 additions & 2 deletions apiv2/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -4,8 +4,8 @@
"description": "",
"author": "",
"engines": {
"node": "^18.20",
"npm": "^10.5"
"node": "^20.17",
"npm": "^10.8"
},
"scripts": {
"build": "nest build",
Expand Down
2 changes: 1 addition & 1 deletion app/.nvmrc
Original file line number Diff line number Diff line change
@@ -1 +1 @@
18.20
20.17
2 changes: 1 addition & 1 deletion app/Dockerfile
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
FROM node:18.20-alpine AS base
FROM node:20.17-alpine AS base

FROM base AS builder
# Check https://github.com/nodejs/docker-node/tree/b4117f9333da4138b03a546ec926ef50a31506c3#nodealpine to understand why libc6-compat might be needed.
Expand Down
4 changes: 2 additions & 2 deletions app/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -80,8 +80,8 @@
"validator": "13.7.0"
},
"engines": {
"node": "^18.20",
"npm": "^10.5",
"node": "^20.17",
"npm": "^10.8",
"yarn": "🍎 This project uses NPM, please do not use YARN. 🍎"
},
"optionalDependencies": {
Expand Down
2 changes: 1 addition & 1 deletion devops/analytics/.nvmrc
Original file line number Diff line number Diff line change
@@ -1 +1 @@
18.20
20.17
4 changes: 2 additions & 2 deletions devops/analytics/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -12,8 +12,8 @@
"clean": "rm -fr node_modules .turbo"
},
"engines": {
"node": "^18.20",
"npm": "^10.5",
"node": "^20.17",
"npm": "^10.8",
"yarn": "🍎 This project uses NPM, please do not use YARN. 🍎"
},
"prettier": {
Expand Down
2 changes: 1 addition & 1 deletion devops/antivirus/.nvmrc
Original file line number Diff line number Diff line change
@@ -1 +1 @@
18.20
20.17
4 changes: 2 additions & 2 deletions devops/antivirus/Dockerfile
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
FROM node:18.20-alpine as build
FROM node:20.17-alpine as build

ENV APP_NAME antivirus

Expand All @@ -12,7 +12,7 @@ RUN --mount=type=cache,target=/build/.npm/cache \
npm install && \
rm -rf node_modules/.cache .npm/cache

FROM node:18.20-alpine as antivirus
FROM node:20.17-alpine as antivirus

ENV APP_NAME antivirus
ENV ENV production
Expand Down
4 changes: 2 additions & 2 deletions devops/antivirus/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -24,8 +24,8 @@
"body-parser": "^1.20.3"
},
"engines": {
"node": "^18.20",
"npm": "^10.5",
"node": "^20.17",
"npm": "^10.8",
"yarn": "🍎 This project uses NPM, please do not use YARN. 🍎"
},
"devDependencies": {
Expand Down
2 changes: 1 addition & 1 deletion knowledge-base-public/.nvmrc
Original file line number Diff line number Diff line change
@@ -1 +1 @@
18.20
20.17
4 changes: 2 additions & 2 deletions knowledge-base-public/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -41,8 +41,8 @@
"tailwindcss": "3.3.3"
},
"engines": {
"node": "^18.20",
"npm": "^10.5",
"node": "^20.17",
"npm": "^10.8",
"yarn": "🍎 This project uses NPM, please do not use YARN. 🍎"
}
}
4 changes: 2 additions & 2 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -30,8 +30,8 @@
"devops/antivirus"
],
"engines": {
"node": "^18.20",
"npm": "^10.5",
"node": "^20.17",
"npm": "^10.8",
"yarn": "🍎 This project uses NPM, please do not use YARN. 🍎"
},
"devDependencies": {
Expand Down
2 changes: 1 addition & 1 deletion packages/ds/.nvmrc
Original file line number Diff line number Diff line change
@@ -1 +1 @@
18.20
20.17
2 changes: 1 addition & 1 deletion packages/lib/.nvmrc
Original file line number Diff line number Diff line change
@@ -1 +1 @@
18.20
20.17
Loading