fix(api): 3624 - Corriger le PUT de la réinscription (#4510)

betagouv · Nov 5, 2024 · 01c0b0e · 01c0b0e
1 parent 6c186c8
commit 01c0b0e
Showing 1 changed file with 6 additions and 6 deletions.
diff --git a/api/src/controllers/young/reinscription.js b/api/src/controllers/young/reinscription.js
@@ -22,12 +22,6 @@ router.put("/", passport.authenticate("young", { session: false, failWithError:
 
     if (!young) return res.status(404).send({ ok: false, code: ERRORS.NOT_FOUND });
 
-    const cohortObj = await CohortModel.findOne({ name: value.cohort });
-    if (!cohortObj) return res.status(404).send({ ok: false, code: ERRORS.NOT_FOUND });
-
-    // Check if the young has access to reinscription
-    if (!hasAccessToReinscription(young, cohortObj)) return res.status(403).send({ ok: false, code: ERRORS.OPERATION_UNAUTHORIZED });
-
     // Validate request body
     const { error, value } = Joi.object({
       schooled: Joi.string().trim().required(),
@@ -53,6 +47,12 @@ router.put("/", passport.authenticate("young", { session: false, failWithError:
       return res.status(400).send({ ok: false, code: ERRORS.INVALID_PARAMS });
     }
 
+    const cohortObj = await CohortModel.findOne({ name: value.cohort });
+    if (!cohortObj) return res.status(404).send({ ok: false, code: ERRORS.NOT_FOUND });
+
+    // Check if the young has access to reinscription
+    if (!hasAccessToReinscription(young, cohortObj)) return res.status(403).send({ ok: false, code: ERRORS.OPERATION_UNAUTHORIZED });
+
     // complete values
     value.status = YOUNG_STATUS.REINSCRIPTION;
     value.originalCohort = young.cohort;