feat: extra database connection properties - take 2 #35
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
djcass44
changed the title
|
LOL, any! Hmm, I think we can do better. No way we can pull in only the valid connection properties? This is typescript after all, want want types. |
| * | ||
| * @default - empty object | ||
| */ | ||
| readonly connectionProps?: any |
|
@berenddeboer I can't for the life of me get it to build with types. It just complains that the module is not declared, despite me clearly declaring it in the
I've tried every possible combination of |
|
I think we're making this way too difficult. You simply wanted ssl right? |
|
@djcass44 Please check my new PR. Could you give this a spin please? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is exactly the same as #34 except it fixes the build issues.
To prove that it works, here's a screenshot of my IDE terminal:
There are a few extra file changes in here (e.g., eslint, package-lock), those were made by progen when I ran
npm run buildso I figured they were supposed to be there. If not, let me know and I'll remove them.