Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create Weighted Pools #166

Open
wants to merge 19 commits into
base: v2
Choose a base branch
from
Open

Create Weighted Pools #166

wants to merge 19 commits into from

Conversation

PaulMcInnis
Copy link
Collaborator

@PaulMcInnis PaulMcInnis commented Nov 5, 2024 •
edited
Loading

Here is the weighted pool creation page!

It features:

  • support for creating weighted pools with 3-8 tokens, with add/remove token buttons
  • duplicate pool creation detection (may be too aggressive currently, as it doesn't respect weight differences)
  • weight inputs with normalization to fix off-by-1 issues
  • inputs for slippage, pool name and symbol name
  • stubbed-out stable pool creation views (but these txs will revert due to an incompatibility between the pool creation helper contract, which uses a v4 stable pool factory vs the deployed stable pool factory version which is v6)

Some things that I can do as a part of this PR or later:

  • allow input for a delegated owner: 0xBA1BA1ba1BA1bA1bA1Ba1BA1ba1BA1bA1ba1ba1B or 0x0... for permanent fees with information popover
  • a proper preview and submit tx page per the design
  • pull in analytics for any other errors
  • refinement for weight inputs UX
  • more accurate gasLimit for pool creation tx (it's fairly high though!)
  • identify issue with SWRError Error: dex subgraph uri s not found in config impacting TokenInput USD prices (may or may not be due to work in this PR)
  • description calling out recommended fee amounts

@vercel Vercel
Copy link

vercel bot commented Nov 5, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
berajs-docs ❌ Failed (Inspect) Nov 5, 2024 9:23pm
storybook ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 5, 2024 9:23pm
v2-bend ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 5, 2024 9:23pm
v2-berps ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 5, 2024 9:23pm
v2-honey ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 5, 2024 9:23pm
v2-hub ❌ Failed (Inspect) Nov 5, 2024 9:23pm
6 Skipped Deployments
Name Status Preview Comments Updated (UTC)
bartio-dex ⬜️ Ignored (Inspect) Visit Preview Nov 5, 2024 9:23pm
bartio-honey ⬜️ Ignored (Inspect) Visit Preview Nov 5, 2024 9:23pm
bartio-lend ⬜️ Ignored (Inspect) Visit Preview Nov 5, 2024 9:23pm
bartio-perps ⬜️ Ignored (Inspect) Visit Preview Nov 5, 2024 9:23pm
bartio-station ⬜️ Ignored (Inspect) Visit Preview Nov 5, 2024 9:23pm
v2-dex ⬜️ Ignored (Inspect) Visit Preview Nov 5, 2024 9:23pm

@PaulMcInnis PaulMcInnis changed the title Feature/balancer/weighted pool create Create Weighted Pools Nov 5, 2024
@PaulMcInnis PaulMcInnis self-assigned this Nov 5, 2024
@PaulMcInnis
<feature>: functional pool UI with token selection, the three pool ty…
6052a4c 
…pes, duplicate detection, and liquidity input. TBD the actual pool creation part
@PaulMcInnis
<feature>: introduce env vars for pool creation helper
be37b32
@PaulMcInnis
<fix>: fix weirdness with token | null typing and with changing the s…
994f0d5 
…ize of that array
@PaulMcInnis
<feature>: wip but added balancer + approval checks at the bottom of …
108fe87 
…the page and started pulling in the SDK v2 pool creation stuff
@PaulMcInnis
WIP attempting to use v3 sdk but its using v5 pool ABIs and probably …
5ae2454 
…wont work
@PaulMcInnis
<feature>: MVP weighted pool creation from FE
284d881
@PaulMcInnis
<fix>: add a basic approval button for token relayer
1399981
@PaulMcInnis
<fix>: salt in one spot
f486611
@PaulMcInnis
<fix>: pull in the multi-token approval that addLiquidity uses
2ca90a4
@PaulMcInnis
<feature>: wip where we are using a hook for pulling in relayer appro…
6dc0129 
…val vs having it inside CreatePageContent
@PaulMcInnis
<fix>: cleaning up by dumping an event finding function we didnt use,…
618fbd8 
… and by properly refactoring the weird base/quote nomenclature that doesnt apply in balancer
@PaulMcInnis
<fix>: switch to a single object tracking Token and input amounts Tok…
000282f 
…enInput
@PaulMcInnis
<feature>: useCreatePool hook
cd0e716
@PaulMcInnis
<fix>: cleanup and properly handle the token inputs with weight inputs
a280955
@PaulMcInnis
<feature>: you can now specify a number of inputs
19f2489
@PaulMcInnis
feat(bex): fix issue with li nesting + properly populate the correct …
6806e58 
…number of token inputs
@PaulMcInnis
feat(bex): allow passing in slippage to useMultipleTokenApprovalsWith…
e3af823 
…Slippage so we can not include it during pool init join tx token approvals
@PaulMcInnis
feat(bex): handle properly user inputs for naming their pool & pool s…
7dc7be8 
…ymbol & prepare to move approvals / submission into a preview page + improved default names
@PaulMcInnis PaulMcInnis force-pushed the feature/balancer/weighted-pool-create branch from 88fb5fe to 7dc7be8 Compare November 5, 2024 19:49
@PaulMcInnis PaulMcInnis marked this pull request as ready for review November 5, 2024 21:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bearpong bearpong Awaiting requested review from bearpong

At least 1 approving review is required to merge this pull request.

Assignees

@PaulMcInnis PaulMcInnis

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@PaulMcInnis