fix(state-transitions): verify deposits against contract #2115
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: nidhi-singh02 <[email protected]>
This reverts commit 099716d.
Signed-off-by: nidhi-singh02 <[email protected]>
Signed-off-by: nidhi-singh02 <[email protected]>
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## state-transition-add-UTs #2115 +/- ##
============================================================
+ Coverage 23.48% 26.71% +3.23%
============================================================
Files 357 357
Lines 16064 16092 +28
Branches 12 12
============================================================
+ Hits 3772 4299 +527
+ Misses 12121 11519 -602
- Partials 171 274 +103
|
abi87
force-pushed
the
verify-deposits-against-contract
branch
from
d28ec4c
to
fb9d020
Compare
abi87
force-pushed
the
verify-deposits-against-contract
branch
from
fb9d020
to
6a191d1
Compare
abi87
commented
Oct 30, 2024
| @@ -87,7 +87,8 @@ func (s *Service[ | |||
| envelope, err := s.retrieveExecutionPayload(ctx, st, blk) | |||
| if err != nil { | |||
| return blk, sidecars, err | |||
| } else if envelope == nil { | |||
There was a problem hiding this comment.
not strictly necessary but OCD kicking in here 😅
abi87
force-pushed
the
verify-deposits-against-contract
branch
from
9c43988
to
64d19e5
Compare
calbera
reviewed
Nov 1, 2024
calbera
previously approved these changes
Nov 1, 2024
abi87
commented
Nov 4, 2024
| if err != nil { | ||
| return err | ||
| } | ||
| eth1Data, err := st.GetEth1Data() | ||
| depositIndex++ |
There was a problem hiding this comment.
@calbera while adding unit tests spot this bug.
st.GetEth1DepositIndex() store the latest processed deposit, hence we need to move it up to process next.
This is similar to what we do in genesis
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Deposit list in execution payload body should be validated against the deposit contracts events to avoid creation of fake validators or censorship of real validators.
To do that this PR:
Moreover it adds much needed logs to state processor (to be filled in time)
Build on top of #2114
Note:
and several like