Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(container): install uv directly to container #4941

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

aarnphm
Copy link
Contributor

@aarnphm aarnphm commented Aug 27, 2024

What does this PR address?

Fixes #(issue)

Before submitting:

@aarnphm aarnphm requested a review from a team as a code owner August 27, 2024 04:50
@aarnphm aarnphm requested review from parano and removed request for a team August 27, 2024 04:50
@@ -20,6 +20,8 @@
{% block SETUP_BENTO_BASE_IMAGE %}
FROM {{ __base_image__ }} as base-container

COPY --from=ghcr.io/astral-sh/uv:latest /uv /bin/uv
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does it work for all architectures(amd64, musl)?

@@ -70,7 +70,6 @@ dependencies = [
"httpx-ws>=0.6.0",
"aiosqlite>=0.20.0",
"InquirerPy>=0.3.4",
"uv",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is also required for locking the packages, should handle the missing uv binary there.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants