Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove templating from CRD #25

Merged
merged 1 commit into from
Jul 8, 2024
Merged

remove templating from CRD #25

merged 1 commit into from
Jul 8, 2024

Conversation

jr200
Copy link
Contributor

@jr200 jr200 commented Jul 8, 2024

Helm doesnt support templating in the crds/ directory...

$ helm install benthos/benthos-captain --generate-name
Error: failed to install CRD crds/pipeline.yaml: error parsing : error converting YAML to JSON: yaml: line 7: could not find expected ':'\n",

Details:

$ helm version
version.BuildInfo{Version:"v3.15.2", GitCommit:"1a500d5625419a524fdae4b33de351cc4f58ec35", GitTreeState:"clean", GoVersion:"go1.22.4"}

@jr200 jr200 force-pushed the fix-crd-template-reference branch from 0e6828a to a149aae Compare July 8, 2024 20:18
charlie-haley
charlie-haley approved these changes Jul 8, 2024
View reviewed changes
Copy link
Member

@charlie-haley charlie-haley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR @jr200

@charlie-haley charlie-haley merged commit c884e63 into benthosdev:main Jul 8, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@charlie-haley charlie-haley charlie-haley approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jr200 @charlie-haley