Fix new migrations to work with strong_migrations
#1199
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I needed to fix new migrations in order for `strong_migrations` to let them pass. Don't think there was anything wrong with orginal approach, I think it is more issue on the `strong_migrations` side, but still there is no reason users should do this manually.
|
I think this looks good. Any ideas for how to make it fully reversible? (I realize it wasn't reversible before) |
|
Looking through this in the fullness of time, I notice:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I needed to fix new migrations in order for
strong_migrationsto let them pass.Don't think there was anything wrong with the original approach, I think it is more issue on the
strong_migrationsside, but still there is no reason users should do this manually.