[WIP] config cleanup v2 #2
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- address oltpbenchmark#209 - create two directory `benchmarks` and `databases` - traces, `plugin.xml` need separated PR - many config are ad-hoc with remote host url hard coded, some are there for several years without any change - if any of them are still needed, just go back to this commit (or any version before it) to grab them out ...
- document how to update the catalog yaml files - copy config.py etc. from config/cleanup branch
- stop travis builtin mysql and postgres - include docker compose file for mysql, postgres, tidb, memsql
- added `Benchmarks.java` in `com.oltpbenchmakr.benchmarks` package as a registry for all existing benchmarks. - it is possible to use reflection to loop all the subpackages and find those extends BenchmarkModule, but it may requires new libraries - ignore generated config in config directory, config generated by `config.py` all starts w/ `generated_` prefix
- some are disabled due to lack of config or requires external program to generate loading data (i.e. tpc-h, tpc-ds, does tpc-ds ever worked? oltpbenchmark#222 ) - auctionmark is failing, but it worked in upstream, need to check it - tidb is disabled for now, because DatabaseType is not updated
- previously no default value is specified, now changed to `TIMESTAMP DEFAULT CURRENT_TIMESTAMP` - there are still errors, but it was there in old travis log as well - https://travis-ci.org/oltpbenchmark/oltpbench/jobs/337420401 ```` The DBMS rejected the transaction without an error code com.mysql.jdbc.exceptions.jdbc4.MySQLIntegrityConstraintViolationException: Duplicate entry '40534595669786707-14750-2199023452243-196691' for key 'PRIMARY' ```` - update gitignore to ignore IDEA stuff and Mac .DS_Store
- auction mysql ddl should be fixed in previous commit - jpab does not have ddl ... - chbench got too many errors and has run for 40 mins on travis - https://travis-ci.org/benchhub/oltpbench/jobs/338773148 - it seems the ddl didn't create the table as expected ...
- just copy mysql's ddl w/ some modification - all have some errors, guess they are not that compatiable to MySQL - MemSQL does not support `REFERENCE` and tooks a while to start - thus the `travis_start.sh` would sleep 30s for memsql
- travis limit is 4 MB, there are too many exceptions, and travis would terminate those jobs (it can finish on local machine though ...) - https://travis-ci.org/benchhub/oltpbench/jobs/338789981
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A cleaner version of #1 , squash commit by hand