Read-only mode and Spring Security example #129
Merged
+527
−59
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* introduce a read-only mode in which you can only consult tasks but not alter them: * controller separation * config for frontend * ui changes to hide buttons * provide Spring Security example * option to alter frontend config at runtime * test with sample config and tests * bump SB and db-scheduler versions
* attempt to fix test failures by creating different tasks for deletion
|
Looks promising, I will set aside some time tomorrow evening for a full review, hopefully 😇 |
geirsagberg
approved these changes
Jan 28, 2025
|
|
||
| public ConfigController(boolean showHistory) { | ||
| public ConfigController(boolean showHistory, Supplier<Boolean> readOnly) { | ||
| this.showHistory = showHistory; |
There was a problem hiding this comment.
Why a supplier, not a value like showHistory?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #126