-
-
Notifications
You must be signed in to change notification settings - Fork 54
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move to a pure PEP621 project configuration. #387
Merged
Merged
Changes from 4 commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
0344722
Move to a pure PEP621 project configuration.
freakboy3742 1ca2ce1
Tweaked the representation license and Homepage.
freakboy3742 5e1a3f2
Add changenote.
freakboy3742 a4b2126
Correct a test that was dependent on file on disk.
freakboy3742 e475635
Update some http references.
freakboy3742 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file was deleted.
Oops, something went wrong.
This file was deleted.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1 @@ | ||
The project was migrated to a PEP621-compatible configuration. |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,7 +1,70 @@ | ||
[build-system] | ||
requires = ["setuptools>=60", "setuptools_scm[toml]>=7.0"] | ||
requires = [ | ||
"setuptools==69.0.0", | ||
"setuptools_scm==8.0.4", | ||
] | ||
build-backend = "setuptools.build_meta" | ||
|
||
[project] | ||
dynamic = ["version"] | ||
name = "rubicon-objc" | ||
description = "A bridge between an Objective C runtime environment and Python." | ||
readme = "README.rst" | ||
requires-python = ">= 3.8" | ||
license.text = "New BSD" | ||
authors = [ | ||
{name="Russell Keith-Magee", email="[email protected]"}, | ||
] | ||
maintainers = [ | ||
{name="BeeWare Team", email="[email protected]"}, | ||
] | ||
keywords = [ | ||
"macOS", | ||
"iOS", | ||
"Objective C", | ||
] | ||
classifiers = [ | ||
"Development Status :: 4 - Beta", | ||
"Intended Audience :: Developers", | ||
"License :: OSI Approved :: BSD License", | ||
"Programming Language :: Objective C", | ||
"Programming Language :: Python :: 3", | ||
"Programming Language :: Python :: 3.8", | ||
"Programming Language :: Python :: 3.9", | ||
"Programming Language :: Python :: 3.10", | ||
"Programming Language :: Python :: 3.11", | ||
"Programming Language :: Python :: 3.12", | ||
"Programming Language :: Python :: 3 :: Only", | ||
"Topic :: Software Development", | ||
] | ||
|
||
[project.urls] | ||
Homepage = "https://beeware.org/rubicon" | ||
Funding = "https://beeware.org/contributing/membership/" | ||
Documentation = "https://rubicon-objc.readthedocs.io/en/latest/" | ||
Tracker = "https://github.com/beeware/rubicon-objc/issues" | ||
Source = "https://github.com/beeware/rubicon-objc" | ||
|
||
[project.optional-dependencies] | ||
dev = [ | ||
"pre-commit == 3.5.0", | ||
"pytest == 7.4.3", | ||
"pytest-tldr == 0.2.5", | ||
"setuptools_scm == 8.0.4", | ||
"tox == 4.11.3", | ||
] | ||
docs = [ | ||
"furo == 2023.9.10", | ||
"pyenchant == 3.2.2", | ||
# Sphinx 7.2 deprecated support for Python 3.8 | ||
"sphinx == 7.1.2 ; python_version < '3.9'", | ||
"sphinx == 7.2.6 ; python_version >= '3.9'", | ||
"sphinx_tabs == 3.4.4", | ||
"sphinx-autobuild == 2021.3.14", | ||
"sphinx-copybutton == 0.5.2", | ||
"sphinxcontrib-spelling == 8.0.0", | ||
] | ||
|
||
[tool.codespell] | ||
skip = ".git,*.pdf,*.svg" | ||
# the way to make case sensitive skips of words etc | ||
|
This file was deleted.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why the pins here instead of minimum versions like before? Surely we support more than just these exact versions.
(The setuptools pyproject.toml docs say that at least setuptools 61.0.0 is required for pyproject.toml support.)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reproducibility. For example, the
dynamic
argument in pyproject.toml wasn't required on setuptools 68.0, but it is required on 69.0. If you use an open ended pin, a project configuration that works on the day of release can break in the future.With a hard pin, we know the configuration works with this specific set of versions, and that won't change. Those versions might not be compatible with future versions of pip, Python etc - but then, we can't make any guarantees about what might happen in future regardless.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
To clarify further: build-requires specify the environment that will be created specifically for the purpose of wheel creation. It's guaranteed to be an isolated environment (unless you specifically disable isolation, in which case you're on your own), so we don't need to maintain maximum compatibility with the end-user's environment. You're specifying the exact environment that you want to be present to build the wheel; an open ended pin undermines that, because we can't guarantee that the build environment will match a configuration that we know works.