Add ability to show next code #1507
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michaelschattgen
force-pushed
the
feature/show-next-code
branch
from
770b3fa
to
4ff4c52
Compare
alexbakker
requested changes
Oct 4, 2024
There was a problem hiding this comment.
Couple of minor issues:
-
The "Tap to reveal" option doesn't hide the next code
-
With tap to reveal enabled, the height of the entry now jumps a bit when revealing/hiding a code. Even with "show next code" disabled.
-
The code is now on the left instead of the right in RTL:
Co-authored-by: Alexander Bakker <[email protected]>
michaelschattgen
force-pushed
the
feature/show-next-code
branch
from
b147e93
to
e4c9a58
Compare
alexbakker
approved these changes
Oct 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We still don't really see the need for this feature but due to high demand we caved. This PR adds a separate toggle in the preferences which allows the user to see the next code under the current code. This has been on ongoing discussion for a while in #923 and it seems like there's a lot of different opinions about it.