Commits on Sep 16, 2024

1. Fix a crash that could occur when deleting a broken icon pack import …

   The following crash could occur when trying to import an icon pack for
   which an empty folder still exists on disk:
   
   ```
   Exception java.lang.IndexOutOfBoundsException: Index -1 out of bounds for length 1
     at jdk.internal.util.Preconditions.outOfBounds (Preconditions.java:64)
     at jdk.internal.util.Preconditions.outOfBoundsCheckIndex (Preconditions.java:70)
     at jdk.internal.util.Preconditions.checkIndex (Preconditions.java:266)
     at java.util.Objects.checkIndex (Objects.java:359)
     at java.util.ArrayList.remove (ArrayList.java:511)
     at com.beemdevelopment.aegis.ui.views.IconPackAdapter.removeIconPack (IconPackAdapter.java:38)
     at com.beemdevelopment.aegis.ui.fragments.preferences.IconPacksManagerFragment.removeIconPack (IconPacksManagerFragment.java:158)
     at com.beemdevelopment.aegis.ui.fragments.preferences.IconPacksManagerFragment.lambda$importIconPack$3 (IconPacksManagerFragment.java:133)
     at androidx.appcompat.app.AlertController$ButtonHandler.handleMessage (AlertController.java:167)
     at android.os.Handler.dispatchMessage (Handler.java:106)
     at android.os.Looper.loopOnce (Looper.java:226)
     at android.os.Looper.loop (Looper.java:313)
     at android.app.ActivityThread.main (ActivityThread.java:8762)
     at java.lang.reflect.Method.invoke
     at com.android.internal.os.RuntimeInit$MethodAndArgsCaller.run (RuntimeInit.java:604)
     at com.android.internal.os.ZygoteInit.main (ZygoteInit.java:1067)
   ```
   
   To reproduce on a debug build of Aegis with the latest aegis-icons
   imported into the app, run the following commands and then try to import
   the same aegis-icons ZIP again:
   
   ```
   $ adb shell
   $ su
   # rm -r /data/data/com.beemdevelopment.aegis.debug/files/icons/c1018b93-4e8c-490a-b575-30dde62a833e/20230523/*
   ```

   

   alexbakker committed Sep 16, 2024
   Configuration menu

   • View commit details
   • Copy full SHA for f860339
   • Browse repository at this point

   Copy the full SHA

   f860339 View commit details

   Browse the repository at this point in the history