Add ability to automatically assign icons to (imported) entries #1172
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michaelschattgen
force-pushed
the
feature/assign-icons
branch
2 times, most recently
from
420fabe
to
3182d20
Compare
alexbakker
requested changes
Sep 6, 2023
There was a problem hiding this comment.
Nice! The UX looks great. Couple of comments though.
Perhaps for a future PR: Do we want to give users a way to select all entries in one go? Currently, if I want to assign icons to all entries in my vault, I have to select them one by one and then tap "Assign icons", which is a little bit cumbersome.
app/src/main/java/com/beemdevelopment/aegis/AssignIconsActivity.java
Outdated
Show resolved
Hide resolved
app/src/main/java/com/beemdevelopment/aegis/AssignIconsActivity.java
Outdated
Show resolved
Hide resolved
app/src/main/java/com/beemdevelopment/aegis/AssignIconsActivity.java
Outdated
Show resolved
Hide resolved
app/src/main/java/com/beemdevelopment/aegis/ui/models/AssignIconEntry.java
Outdated
Show resolved
Hide resolved
app/src/main/java/com/beemdevelopment/aegis/ui/views/AssignIconHolder.java
Outdated
Show resolved
Hide resolved
app/src/main/java/com/beemdevelopment/aegis/AssignIconsActivity.java
Outdated
Show resolved
Hide resolved
app/src/main/java/com/beemdevelopment/aegis/ui/views/AssignIconHolder.java
Show resolved
Hide resolved
app/src/main/java/com/beemdevelopment/aegis/ui/views/EntryHolder.java
Outdated
Show resolved
Hide resolved
app/src/main/java/com/beemdevelopment/aegis/ui/MainActivity.java
Outdated
Show resolved
Hide resolved
michaelschattgen
force-pushed
the
feature/assign-icons
branch
from
3182d20
to
bf97477
Compare
alexbakker
requested changes
Sep 9, 2023
app/src/main/java/com/beemdevelopment/aegis/AssignIconsActivity.java
Outdated
Show resolved
Hide resolved
app/src/main/java/com/beemdevelopment/aegis/AssignIconsActivity.java
Outdated
Show resolved
Hide resolved
app/src/main/java/com/beemdevelopment/aegis/AssignIconsActivity.java
Outdated
Show resolved
Hide resolved
app/src/main/java/com/beemdevelopment/aegis/AssignIconsActivity.java
Outdated
Show resolved
Hide resolved
michaelschattgen
force-pushed
the
feature/assign-icons
branch
from
bf97477
to
387f3f3
Compare
More progress Open IconPicker dialog on click Add ability to reset Fix changing icons Cleanup Add ability to assign icons after import PR fixes
michaelschattgen
force-pushed
the
feature/assign-icons
branch
from
387f3f3
to
1a6f85c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request adds a new activity allowing the user to quickly assign icons to (imported) entries. This activity automatically finds the best matching icon. This screen is accessible through:
Eventually I also want to present this activity after importing an icon pack. However that requires a bit more effort and since this is already a big feature I decided to do that later.
Upon opening this activity Aegis will automatically pick the first suggested icon of the first available icon pack, if that's not the desired icon the user can tap the card an manually pick one.
Do note that this feature is only available if an icon pack is installed.
Closes #773.
studio64_YLCOH1RJGl.mp4