-
-
Notifications
You must be signed in to change notification settings - Fork 386
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refer to groups by UUID #1078
Refer to groups by UUID #1078
Conversation
Awesome work as always! Unfortunately I haven't had time to look at this yet, and I may not be able to get to it in the next couple of weeks either. Sorry about that. Starting February I should have some more time for Aegis. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Apologies for the delay. I've added some initial comments. Don't be afraid to push back if you think I'm asking for something that wouldn't work well. With a large patch like this it's easy to miss details.
app/src/main/java/com/beemdevelopment/aegis/vault/VaultGroup.java
Outdated
Show resolved
Hide resolved
app/src/main/java/com/beemdevelopment/aegis/vault/VaultGroup.java
Outdated
Show resolved
Hide resolved
app/src/main/java/com/beemdevelopment/aegis/vault/VaultGroup.java
Outdated
Show resolved
Hide resolved
app/src/main/java/com/beemdevelopment/aegis/importers/AegisImporter.java
Show resolved
Hide resolved
app/src/main/java/com/beemdevelopment/aegis/ui/GroupManagerActivity.java
Outdated
Show resolved
Hide resolved
app/src/main/java/com/beemdevelopment/aegis/vault/VaultRepository.java
Outdated
Show resolved
Hide resolved
app/src/main/java/com/beemdevelopment/aegis/vault/VaultRepository.java
Outdated
Show resolved
Hide resolved
b6c1f80
to
5bd190d
Compare
I've finally gotten round to addressing the feedback, everything you suggested was okay. The only thing I'm still not sure about is how to get the "New group" button into the dropdown checkboxes so I've reverted that to the original approach for now and see if I can come up with a workaround. It would probably be possible to migrate entries that claim to be in a group that has been discarded due to duplicate names to the UUID of the group of the same name which was kept but this would be a super rare circumstance and the user could easily add them back to the group so I'm not sure if that would be worth it, what do you think? |
9ff4c7b
to
ba91010
Compare
Finally had some time to look at this again. Overall I'm pretty happy with this, but I'd like to take another look at the migration logic later this week before merging this, because I don't think I fully understand it yet. For example, I don't understand why we need to call Also, I've made a couple of minor changes here and there, I hope you don't mind. |
This was because
No problem, the group model is much better than what I had |
c346507
to
48c74a2
Compare
- Also lays the foundations for adding entries to multiple groups and changing group names Co-authored-by: Alexander Bakker <[email protected]>
48c74a2
to
5c86e5c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a lot!
Happy new year!
For now entries can only be added to 1 group, but basically everything needed to make adding to multiple possible is already laid down here, and I'll be happy to work on that if this PR is merged.