Bugfix: #371 #372
Open
Bugfix: #371 #372
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
November 6, 2024 15:02
hatjek
requested changes
Nov 8, 2024
There was a problem hiding this comment.
@bhoellbacher I think we want to keep the cache behavior in Besca, but not in the pipeline. I would suggest to add "cache" as an additional parameter to the "read_mtx" function, and change this parameter in the pipeline, but keep the default in Besca as True. What do you think?
There was a problem hiding this comment.
Sounds good.
Let me know what you think of the drafted code changes.
hatjek
approved these changes
Nov 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rerunning the pipeline with changed thresholds leads to an outdated .h5ad being loaded.
Setting cache=False when using scanpy read, resolves this issue.
Note: This pull request contains additional commits from previous pull requests.