-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Increase argument size to 18 #29
Conversation
WalkthroughThe changes involve a minor version update in the Changes
Poem
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (2)
- mix.exs (1 hunks)
- src/kinda.zig (2 hunks)
Files skipped from review due to trivial changes (1)
- mix.exs
Additional comments not posted (2)
src/kinda.zig (2)
266-266
: LGTM!The code changes to support 18 arguments in the
VariadicArgs
function are approved.
291-291
: LGTM!The code changes to support 18 arguments in the
variadic_call
function are approved.
Summary by CodeRabbit
New Features
NIFFunc
function to support handling of up to 18 arguments, increasing flexibility for users.Bug Fixes
NIFFunc
function.