-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve IRDL region constraints #234
Open
jackalcooper
wants to merge
15
commits into
main
Choose a base branch
from
improve-irdl-region-constraints
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 13 commits
Commits
Show all changes
15 commits
Select commit
Hold shift + click to select a range
23757a2
add more constraints
jackalcooper b734492
Update elixir_ast_dialect.ex
jackalcooper b627343
use builtin mod and func
jackalcooper adafc70
Merge branch 'main' into improve-irdl-region-constraints
jackalcooper ecc8a13
Merge branch 'main' into improve-irdl-region-constraints
jackalcooper fc69a17
Merge branch 'main' into improve-irdl-region-constraints
jackalcooper 87f8fa3
Merge branch 'main' into improve-irdl-region-constraints
jackalcooper f62cd35
support sized region
jackalcooper 78159b8
add more cases
jackalcooper 622e5e8
minor refactor
jackalcooper 082a31b
Revert "minor refactor"
jackalcooper 167af88
Update slang.ex
jackalcooper 5ab3a9c
Update slang.ex
jackalcooper 42970ec
Merge branch 'main' into improve-irdl-region-constraints
jackalcooper 8f2df3c
Merge branch 'main' into improve-irdl-region-constraints
jackalcooper File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,7 @@ | ||
defmodule TestRegion do | ||
@moduledoc "An example to showcase the a region dialect in IRDL test." | ||
use Beaver.Slang, name: "test_region" | ||
defop any_region(i = {:single, Type.i32()}), do: [], regions: [:any] | ||
defop any_region2(i = {:single, Type.i32()}), do: [], regions: [:any, :any] | ||
defop sized_region(), regions: {:sized, 11} | ||
end |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
dedicated
regions
block won't work well when we want to add a constrain like this: