-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Mypy config #179
base: master
Are you sure you want to change the base?
feat: Mypy config #179
Conversation
Signed-off-by: nstarman <[email protected]>
Signed-off-by: nstarman <[email protected]>
Signed-off-by: nstarman <[email protected]>
Signed-off-by: nstarman <[email protected]>
Signed-off-by: nstarman <[email protected]>
Hmm. Not sure what changed with |
@nstarman The error says that the script expected
but
Ah, you not like to squash and merge? Would you prefer another way? |
I normally like Squash & Merge, but for this PR I was trying to keep each commit a distinct contribution: the configuration, then adding typing to each module. You can Squash & Merge, of course, I was just suggesting that for this PR a normal merge was appropriate. |
@nstarman Ah, that makes total sense! Thanks for the explanation. I’m also happy to merge without squashing if the commits are nicely structured. I don’t feel strongly any particular way. :) |
Fixes #147
Plz don't squash.