-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
beam 3174 - open telemetry #1841
Draft
cdhanna
wants to merge
29
commits into
main
Choose a base branch
from
feature/beam-3174
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # client/Packages/com.beamable.server/CHANGELOG.md
Have a WebGL build, friend. f873290006343a5a8bff0113fadef280acdcdbcd |
# Conflicts: # client/Packages/com.beamable.server/CHANGELOG.md # microservice/microservice/dbmicroservice/BeamableMicroService.cs # microservice/microservice/dbmicroservice/EasyWebSocket.cs # microservice/microservice/dbmicroservice/IConnection.cs # microservice/microservice/dbmicroservice/MicroserviceArgs.cs # microservice/microserviceTests/microservice/TestArgs.cs # microservice/microserviceTests/microservice/TestSocket.cs
Have a WebGL build, friend. bb111a1558506c5543e4a866193550dcfea74657 |
# Conflicts: # client/Packages/com.beamable.server/CHANGELOG.md # microservice/microservice/dbmicroservice/MicroserviceBootstrapper.cs
Have a WebGL build, friend. b6a96c71a67a1468ef13a303afcde6f0d49d0136 |
# Conflicts: # client/Packages/com.beamable.server/Editor/DockerCommands/RunImageCommand.cs # microservice/microservice/dbmicroservice/BeamableMicroService.cs # microservice/microservice/dbmicroservice/MicroserviceArgs.cs # microservice/microservice/dbmicroservice/MicroserviceBootstrapper.cs # microservice/microserviceTests/microservice/TestArgs.cs
Have a WebGL build, friend. e24f766086a99f0381f4a95586fcf9ba11132aff |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket
https://disruptorbeam.atlassian.net/browse/BEAM-3174
Brief Description
Includes Open Telemetry (OTEL) tracing instrumentation that follows standard OTEL.
In order to enable OTEL, the container needs an env var for
EMIT_OTEL=true
, and then it follows the standard https://github.com/open-telemetry/opentelemetry-dotnet/blob/main/src/OpenTelemetry.Exporter.OpenTelemetryProtocol/README.md#environment-variables OTEL env vars to direct the telemetry.I need to write a doc wiki file before this goes in.
Also, I'm not sure we want to submit this before we have a way to direct it anywher.e
Checklist
/wiki/BEAM-1234.md
? You need to provide a docs file.Notes
When you are merging a feature branch into
main
, please squash merge and make sure the final commit contains any relevent JIRA ticket number. If you are merging frommain
tostaging
, orstaging
toproduction
, please use a regular merge commit.