Add Data URI function #20
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Troy Rosenberg <[email protected]> Co-authored-by: Rob West <[email protected]>
Co-authored-by: Troy Rosenberg <[email protected]> Co-authored-by: Rob West <[email protected]>
Co-authored-by: Troy Rosenberg <[email protected]> Co-authored-by: Rob West <[email protected]>
dbernheisel
commented
Dec 14, 2018
| elixir 1.6.1 | ||
| erlang 20.2.2 |
There was a problem hiding this comment.
I flipped the order because there's a bug in asdf-erlang where the install processes ends in a non-0 code (even though it successfully installed), which causes asdf to stop installing the rest of the tools. Moving it to the end will avoid the issue.
drapergeek
approved these changes
Dec 14, 2018
|
|
||
| `<%= img_tag(Brady.data_uri("images/placeholder.gif"), alt: "Celery Man" %>` | ||
|
|
||
| It's not recommended to inline images that are more than a few kilobytes in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Effort towards responsive images outline in this issue: #19
This only implements the Data URI function.