Update -n parameter in %setup macro #201
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GitHub archives are created with the repository name prefix. This change ensures correct Source0 extraction during the RPM build. Signed-off-by: Martin Styk <[email protected]>
p3ck
approved these changes
Jan 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GitHub archives are created with the repository name as a prefix.
For instance, requesting an archive from:
results in a file named beaker-beaker-28.3.tar.gz, as indicated by the content-disposition header:
Although the Spectool and RPM toolchain store the file based on the requested path, resulting in beaker-28.3.tar.gz, the internal structure of the tarball reflects the original GitHub archive naming. This discrepancy can cause issues during the RPM build process.
This commit adjusts the %setup -n parameter in the spec file to align with the GitHub archive's internal structure, ensuring correct extraction and building.
The change has been manually tested in COPR and with rpmbuild/spectool.
We can't catch this problem in CI right now because of the way Packit works. Packit replaces both sources and the %setup macro.