Added array_fill_keys support (vimeo#2512)

* Added array_fill_keys support * Removed unnecessary array_fill_keys phpdoc
bdsl · Dec 27, 2019 · 006f788 · 006f788
1 parent 6b81f8c
commit 006f788
Show file tree

Hide file tree

Showing 4 changed files with 22 additions and 2 deletions.
diff --git a/src/Psalm/Internal/Analyzer/ProjectAnalyzer.php b/src/Psalm/Internal/Analyzer/ProjectAnalyzer.php
@@ -1187,7 +1187,6 @@ public function setIssuesToFix(array $issues)
 
     public function setAllIssuesToFix(): void
     {
-        /** @var array<string, true> $keyed_issues */
         $keyed_issues = array_fill_keys(static::getSupportedIssuesToFix(), true);
 
         $this->setIssuesToFix($keyed_issues);

diff --git a/src/Psalm/Internal/Fork/Pool.php b/src/Psalm/Internal/Fork/Pool.php
@@ -287,7 +287,6 @@ private function readResultsFromChildren()
 
         // Create an array for the content received on each stream,
         // indexed by resource id.
-        /** @var array<int, string> $content */
         $content = array_fill_keys(array_keys($streams), '');
 
         $terminationMessages = [];

diff --git a/src/Psalm/Internal/Stubs/CoreGenericFunctions.php b/src/Psalm/Internal/Stubs/CoreGenericFunctions.php
@@ -217,3 +217,17 @@ function array_key_exists($key, array $search) : bool
 function array_merge_recursive(array $arr, array ...$arr2)
 {
 }
+
+/**
+ * @psalm-template TKey as array-key
+ * @psalm-template TValue
+ *
+ * @param array<TKey> $keys
+ * @param TValue $value
+ *
+ * @return array<TKey, TValue>
+ * @psalm-pure
+ */
+function array_fill_keys(array $keys, $value): array
+{
+}
diff --git a/tests/FunctionCallTest.php b/tests/FunctionCallTest.php
@@ -2334,6 +2334,14 @@ function getCharPairs(string $line) : array {
                         );
                     }'
             ],
+            'arrayFillKeys' => [
+                '<?php
+                    $keys = [1, 2, 3];
+                    $result = array_fill_keys($keys, true);',
+                'assertions' => [
+                    '$result' => 'array<int, true>',
+                ],
+            ],
         ];
     }