Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bump gleam version to at least 1.1.0 #23

Merged
merged 3 commits into from
Apr 21, 2024
Merged
Show file tree
Hide file tree
Changes from 2 commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .github/workflows/test.yml
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
name: test

env:
GLEAM_VERSION: "1.1.0-rc3"
GLEAM_VERSION: "1.1.0"

on:
push:
Expand Down Expand Up @@ -51,7 +51,7 @@ jobs:
strategy:
fail-fast: true
matrix:
erlang: ["26", "25", "27.0-rc1"]
erlang: ["26", "25", "27.0-rc3"]
steps:
- uses: actions/checkout@v4
- uses: actions/cache/restore@v4
Expand Down
2 changes: 2 additions & 0 deletions gleam.toml
Original file line number Diff line number Diff line change
@@ -1,6 +1,8 @@
name = "code_review"
version = "1.0.0"

gleam = ">= 1.1.0 and < 2.0.0"
TanklesXL marked this conversation as resolved.
Show resolved Hide resolved

# Fill out these fields if you intend to generate HTML documentation or publish
# your project to the Hex package manager.
#
Expand Down
2 changes: 1 addition & 1 deletion manifest.toml
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ packages = [
]

[requirements]
birdie = { version = ">= 1.1.2 and < 2.0.0"}
birdie = { version = ">= 1.1.2 and < 2.0.0" }
filepath = { version = ">= 1.0.0 and < 2.0.0" }
glance = { version = ">= 0.8.2 and < 1.0.0" }
glance_printer = { version = ">= 1.1.0 and < 2.0.0" }
Expand Down
20 changes: 10 additions & 10 deletions src/code_review.gleam
Original file line number Diff line number Diff line change
Expand Up @@ -160,11 +160,11 @@ fn do_visit_expressions(
visit_statements(rules, statements)
}
glance.RecordUpdate(
module: _,
constructor: _,
record: record,
fields: fields,
) -> {
module: _,
constructor: _,
record: record,
fields: fields,
) -> {
let new_rules = do_visit_expressions(rules, record)

use acc_rules, #(_, expr) <- list.fold(fields, new_rules)
Expand All @@ -182,11 +182,11 @@ fn do_visit_expressions(
do_visit_expressions(rules, expr)
}
glance.FnCapture(
label: _,
function: function,
arguments_before: arguments_before,
arguments_after: arguments_after,
) -> {
label: _,
function: function,
arguments_before: arguments_before,
arguments_after: arguments_after,
) -> {
list.fold(
list.append(arguments_before, arguments_after),
rules,
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -43,10 +43,10 @@ fn expression_visitor(
)

glance.BinaryOperator(
glance.Concatenate,
glance.String(_),
glance.String(_),
) -> #(
glance.Concatenate,
glance.String(_),
glance.String(_),
) -> #(
[
rule.error(
at: context.current_location,
Expand Down