-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Significant enhancements #12
Open
benjie
wants to merge
52
commits into
bcherny:master
Choose a base branch
from
benjie:master
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 31 commits
Commits
Show all changes
52 commits
Select commit
Hold shift + click to select a range
4f62e0d
Fixes
benjie 1c39616
More fixes
benjie 44da30d
More compatibility
benjie 58a7389
Increased logging
benjie a8acccf
Only output stack when error occurs
benjie 8e17ae9
More fixes, merge visitors
benjie 630e6e7
More progress
benjie 106c3ca
Better debugging
benjie d7a282d
More progress
benjie 10348d9
Generics
benjie 3788217
Add explicit prettier config, matching old formatting (roughly)
benjie d223168
Add prettier
benjie d9699a7
Autoformat with 'yarn prettier:fix'
benjie 85fce70
Assert prettier
benjie fe6418d
Merge branch 'prettier'
benjie fde88fc
Resolve some TypeScript woes
benjie 03a172d
Progress
benjie 735953d
Tidy
benjie 1d79f26
Fix exact
benjie 9797737
Fix
benjie f2f8f8c
Disable ordered imports temporarily
benjie f2959c7
Fix
benjie 131c5dd
Fix types
benjie ba238ae
InterfaceDeclaration
benjie 61385d3
Reduce logging
benjie 186cfb8
Reduce logging
benjie 9b565d3
Add support for type spreads via intersections
benjie 960d75d
Shorthand for object types that are only spreads
benjie 63e9bf7
More complex function
benjie 2cae956
Remove 'type' from exports
benjie 77de757
Reproduce issue with missing parenthesis
benjie 795f963
Merge remote-tracking branch 'upstream/master'
benjie 6099bef
Upgrade deps
benjie 4920570
Revert
benjie cef452c
Remove many @ts-ignore calls
benjie 342b4ea
Lies
benjie 7a6c42a
Fix more types
benjie 3109589
Remove extra parens
benjie a198b01
Add comment on warnings
benjie 8126796
rm console.dir
benjie df91804
rm noop files
benjie a9ca876
Parenthesize functions in union types
benjie 7843d19
Copy comments across
benjie c29ec62
Add support for function rest params
benjie 9915591
Copy comments
benjie c86c05b
Indexer comment test
benjie 3963ffe
Better types
benjie 798cb28
Remove whitespace config because we have prettier
benjie 797c0d9
Manually dedupe @babel/types
benjie 04ccd25
noImplicitAny
benjie 329e351
Merge remote-tracking branch 'upstream/master'
benjie 4f68ec9
Updatable tests (thanks @DylanVann)
benjie File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,6 @@ | ||
module.exports = { | ||
printWidth: 80, | ||
semi: false, | ||
singleQuote: true, | ||
trailingComma: 'none', | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Revert?