[DEVSU-2468] add POST route to gkb user creation #409
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment has been minimized.
This comment has been minimized.
DEVSU-2468
kttkjl
force-pushed
the
feat/DEVSU-2468-gkb-user-creation-separate
branch
from
031c5a6 to
e18e361
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #409 +/- ##
===========================================
- Coverage 76.96% 76.85% -0.12%
===========================================
Files 179 179
Lines 6038 6048 +10
Branches 696 697 +1
===========================================
+ Hits 4647 4648 +1
- Misses 1314 1322 +8
- Partials 77 78 +1 ☔ View full report in Codecov by Sentry. |
This comment has been minimized.
This comment has been minimized.
Nithriel
reviewed
Nov 29, 2024
app/routes/graphkb/index.js
Outdated
| } catch (error) { | ||
| logger.error(error); | ||
| return res.status(StatusCodes.SERVICE_UNAVAILABLE).json({ | ||
| message: 'GraphKB user creation error', |
This comment has been minimized.
This comment has been minimized.
elewis2
requested changes
Dec 23, 2024
This comment has been minimized.
This comment has been minimized.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Separate graphkb user creation from ipr user creation, so everything is more in sync in the front-end
See DESVU-2468 for current blocker, which is not enough permissions on IPR API agent user