Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Partition weather station model predictions table, part 1 #4059

Open
wants to merge 11 commits into
base: main
Choose a base branch
from

Conversation

conbrad
Copy link
Collaborator

@conbrad conbrad commented Nov 5, 2024

  • Migrations for partitioning the weather_station_model_predictions from the months we had data this past fire season, and 3 months into the future
  • Docker image, build and job for running the data migrations asynchronously
  • Will follow up with a job to archive/detach older partitions, and a monthly job for create new partitions

Test Links:

Landing Page
MoreCast
Percentile Calculator
C-Haines
FireBat
FireBat bookmark
Auto Spatial Advisory (ASA)
HFI Calculator

Copy link

codecov bot commented Nov 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 80.37%. Comparing base (c920992) to head (9c0393e).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #4059   +/-   ##
=======================================
  Coverage   80.37%   80.37%           
=======================================
  Files         309      309           
  Lines       11841    11841           
  Branches      537      537           
=======================================
  Hits         9517     9517           
  Misses       2138     2138           
  Partials      186      186           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@conbrad conbrad closed this Nov 5, 2024
@conbrad conbrad reopened this Nov 6, 2024
Copy link
Collaborator

@brettedw brettedw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work, looks good. I imagine they'll be some down time and an increase in db size temporarily with all the indexes being generated?

if [ -z ${PG_PASSWORD+0} ]
then
echo "PG_PASSWORD not specified"
echo "Specify a postgress password"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

super nit: extra 's' on postgres in a few places here

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done in: 9c0393e

- name: "TABLE"
description: "The table that is partitioned"
required: true
value: "prod"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this intentionally 'prod'?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy-pasta thanks for catching

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done in: 9c0393e

Copy link

sonarcloud bot commented Nov 6, 2024

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants