Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix missing mountain #4051

Merged
merged 5 commits into from
Oct 31, 2024
Merged

Fix missing mountain #4051

merged 5 commits into from
Oct 31, 2024

Conversation

dgboss
Copy link
Collaborator

@dgboss dgboss commented Oct 30, 2024

  • Use a png instead of an svg
  • fix a couple data-testid attributes

Test Links:

Landing Page
MoreCast
Percentile Calculator
C-Haines
FireBat
FireBat bookmark
Auto Spatial Advisory (ASA)
HFI Calculator

Copy link

codecov bot commented Oct 30, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 80.10%. Comparing base (ee26b71) to head (ad52f41).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #4051   +/-   ##
=======================================
  Coverage   80.10%   80.10%           
=======================================
  Files         304      304           
  Lines       11550    11550           
  Branches      537      537           
=======================================
  Hits         9252     9252           
  Misses       2112     2112           
  Partials      186      186           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

sonarcloud bot commented Oct 30, 2024

@dgboss dgboss temporarily deployed to production October 31, 2024 15:15 Inactive
@dgboss dgboss merged commit 291e0cc into main Oct 31, 2024
25 checks passed
@dgboss dgboss deleted the bug/missing-mountain branch October 31, 2024 15:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants