Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TPI layout overhaul #4050

Merged
merged 2 commits into from
Oct 30, 2024
Merged

TPI layout overhaul #4050

merged 2 commits into from
Oct 30, 2024

Conversation

dgboss
Copy link
Collaborator

@dgboss dgboss commented Oct 29, 2024

  • Use the mountain svg as a background image
  • Use svgs for the 'flags' so they can be transparent
  • Enhance contrast of text as per figma design
  • Change tabpanel backgrounf to match figma design
    image

Closes #3914

Test Links:

Landing Page
MoreCast
Percentile Calculator
C-Haines
FireBat
FireBat bookmark
Auto Spatial Advisory (ASA)
HFI Calculator

Copy link

sonarcloud bot commented Oct 29, 2024

Copy link

codecov bot commented Oct 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 80.63%. Comparing base (06c42d9) to head (bbfa43a).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4050      +/-   ##
==========================================
+ Coverage   80.10%   80.63%   +0.52%     
==========================================
  Files         304      304              
  Lines       11550    11550              
  Branches      537      537              
==========================================
+ Hits         9252     9313      +61     
- Misses       2112     2119       +7     
+ Partials      186      118      -68     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dgboss dgboss requested a review from brettedw October 29, 2024 21:56
Copy link
Collaborator

@brettedw brettedw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work! I like that text shadow 👌

@dgboss dgboss temporarily deployed to production October 30, 2024 15:52 Inactive
@dgboss dgboss merged commit ee26b71 into main Oct 30, 2024
25 checks passed
@dgboss dgboss deleted the task/tpi-image/3914 branch October 30, 2024 16:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ASA: Sidebar Topographic Responsive Layout
3 participants