Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix error when actuals are missing #4045

Merged
merged 10 commits into from
Oct 28, 2024
Merged

Fix error when actuals are missing #4045

merged 10 commits into from
Oct 28, 2024

Conversation

dgboss
Copy link
Collaborator

@dgboss dgboss commented Oct 24, 2024

  • Omit actual rows when submitting a forecast
  • Add border and tooltip to actual cells if expected data is missing from WF1.

Closes #3956

Test Links:

Landing Page
MoreCast
Percentile Calculator
C-Haines
FireBat
FireBat bookmark
Auto Spatial Advisory (ASA)
HFI Calculator

Visual indication of missing actuals
Copy link

codecov bot commented Oct 24, 2024

Codecov Report

Attention: Patch coverage is 75.00000% with 5 lines in your changes missing coverage. Please review.

Project coverage is 80.63%. Comparing base (1552aaa) to head (114a205).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
...b/src/features/moreCast2/components/ActualCell.tsx 76.92% 3 Missing ⚠️
...res/moreCast2/components/GridComponentRenderer.tsx 75.00% 1 Missing ⚠️
web/src/features/moreCast2/saveForecasts.ts 0.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4045      +/-   ##
==========================================
+ Coverage   79.99%   80.63%   +0.63%     
==========================================
  Files         303      304       +1     
  Lines       11554    11550       -4     
  Branches      549      537      -12     
==========================================
+ Hits         9243     9313      +70     
+ Misses       2126     2119       -7     
+ Partials      185      118      -67     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@brettedw brettedw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, nice work!

Copy link

sonarcloud bot commented Oct 28, 2024

@dgboss dgboss temporarily deployed to production October 28, 2024 15:38 Inactive
@dgboss dgboss merged commit 8c21ff3 into main Oct 28, 2024
25 checks passed
@dgboss dgboss deleted the bug/missing-actuals/3956 branch October 28, 2024 16:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

MoreCast: Missing Actuals Error
3 participants