Replace bdd tests with parametrized tests for fba vs redapp tests #4044
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4044 +/- ##
=======================================
Coverage 79.99% 79.99%
=======================================
Files 303 303
Lines 11554 11554
Branches 549 549
=======================================
Hits 9243 9243
Misses 2126 2126
Partials 185 185 ☔ View full report in Codecov by Sentry. |
|
brettedw
approved these changes
Oct 24, 2024
| # M2 The redapp error margin is HUGE! | ||
| # M4 Redapp margin bad. | ||
| # O1A Spreadsheet bad | ||
| # O1B Spreadsheet bad |
There was a problem hiding this comment.
I know you didn't write them but these are some interesting notes....haha
There was a problem hiding this comment.
Keeping them because they might hold some key insights in the future!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
api/app/tests/fba_calc/test_fba_error_redapp.pybecause of the long line inputsCloses #4020
Test Links:
Landing Page
MoreCast
Percentile Calculator
C-Haines
FireBat
FireBat bookmark
Auto Spatial Advisory (ASA)
HFI Calculator