BUI calculations #4042
Merged
BUI calculations #4042
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #4042 +/- ##
==========================================
+ Coverage 80.10% 80.37% +0.26%
==========================================
Files 304 309 +5
Lines 11550 11841 +291
Branches 537 537
==========================================
+ Hits 9252 9517 +265
- Misses 2112 2138 +26
Partials 186 186 ☔ View full report in Codecov by Sentry. |
|
Closing to free up resources |
conbrad
reviewed
Nov 4, 2024
dgboss
reviewed
Nov 4, 2024
dgboss
reviewed
Nov 4, 2024
| async def put_object(self, key: str, body: Any): | ||
| await self.client.put_object(Bucket=self.bucket, Key=key, Body=body) | ||
|
|
||
| async def persist_raster_data(self, temp_dir: str, key: str, transform, projection, values, no_data_value) -> str: |
There was a problem hiding this comment.
nit: I feel like the client should just be passed a tif to save and that it shouldn't concern itself with creating a raster from the input parameters.
conbrad
approved these changes
Nov 4, 2024
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Test Links:
Landing Page
MoreCast
Percentile Calculator
C-Haines
FireBat
FireBat bookmark
Auto Spatial Advisory (ASA)
HFI Calculator