Use nginx stable from dockerhub #4038
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4038 +/- ##
==========================================
- Coverage 80.56% 80.05% -0.52%
==========================================
Files 303 303
Lines 11564 11564
Branches 549 549
==========================================
- Hits 9317 9257 -60
+ Misses 2129 2122 -7
- Partials 118 185 +67 ☔ View full report in Codecov by Sentry. |
dgboss
reviewed
Oct 22, 2024
dgboss
approved these changes
Oct 22, 2024
Co-authored-by: dgboss <[email protected]>
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
Dockerfile.web
Outdated
|
|
||
| # Add application sources | ||
| ADD ./openshift/nginx.conf "${NGINX_CONF_PATH}" | ||
| ADD ./openshift/nginx.conf /etc/nginx/nginx.conf |
Check notice
Code scanning / SonarCloud
Prefer COPY over ADD for copying local resources
brettedw
approved these changes
Oct 22, 2024
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Test Links:
Landing Page
MoreCast
Percentile Calculator
C-Haines
FireBat
FireBat bookmark
Auto Spatial Advisory (ASA)
HFI Calculator