Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Limit use of USE_WFWX #4002

Merged
merged 6 commits into from
Oct 16, 2024
Merged

Limit use of USE_WFWX #4002

merged 6 commits into from
Oct 16, 2024

Conversation

dgboss
Copy link
Collaborator

@dgboss dgboss commented Oct 11, 2024

  • Remove USE_WFWX env variable
  • Remove use_wfwx() from wfwx_api
  • All WFWX API calls are mocked in tests, including bdd tests

Test Links:

Landing Page
MoreCast
Percentile Calculator
C-Haines
FireBat
FireBat bookmark
Auto Spatial Advisory (ASA)
HFI Calculator

Copy link

codecov bot commented Oct 11, 2024

Codecov Report

Attention: Patch coverage is 57.14286% with 3 lines in your changes missing coverage. Please review.

Project coverage is 80.05%. Comparing base (71e17bb) to head (d8b15d4).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
api/app/hourlies.py 0.00% 3 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #4002   +/-   ##
=======================================
  Coverage   80.04%   80.05%           
=======================================
  Files         302      302           
  Lines       11477    11456   -21     
  Branches      549      549           
=======================================
- Hits         9187     9171   -16     
+ Misses       2105     2100    -5     
  Partials      185      185           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

sonarcloud bot commented Oct 16, 2024

Copy link
Collaborator

@conbrad conbrad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice cleanup!

api/app/stations.py Show resolved Hide resolved
api/app/stations.py Show resolved Hide resolved
Copy link
Collaborator

@brettedw brettedw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👌👌👌

@dgboss dgboss marked this pull request as ready for review October 16, 2024 16:33
@dgboss dgboss merged commit 6b15aa7 into main Oct 16, 2024
23 checks passed
@dgboss dgboss deleted the task/use-wfwx-review/2865 branch October 16, 2024 18:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants