Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump base image Ubuntu to 24.04, Bump gdal to 3.9 #3995

Merged
merged 139 commits into from
Oct 15, 2024
Merged

Conversation

conbrad
Copy link
Collaborator

@conbrad conbrad commented Oct 10, 2024

  • Rebuilt wps-api-baseto use osgeo/gdal:ubuntu-small-3.9.2 which comes with Ubuntu 24.04, python 3.12.3 and gdal 3.9.2
  • Updates tippecanoe to 2.62.5
  • Installing gdal for builds requires a few more flags otherwise it won't recognize the numpy installation
  • Images already have GID 1000 and UID 1000 so a new user with ID 1010 is created and added to existing GID 1000 for mount permissions
  • Uses cutlineWkt instead of cutlineSQL from gdal to avoid issues with gdal postgres search paths
  • A bunch of fixes to C-Haines code that started failing tests with new poetry updates
  • Documentation and setup script updates to reference the new python version
  • Removes shapely from tileserv project since it doesn't build with python 3.12.3 and we don't use it anymore

Test Links:

Landing Page
MoreCast
Percentile Calculator
C-Haines
FireBat
FireBat bookmark
Auto Spatial Advisory (ASA)
HFI Calculator

@conbrad conbrad requested a review from brettedw October 10, 2024 19:02
@dgboss
Copy link
Collaborator

dgboss commented Oct 10, 2024

In deployment.yaml there are two jobs that include a step to install the oc cli but the jobs still run on ubuntu-22.04:

  • deploy-dev
  • deploy-dev-queue
    Is this intentional?

@conbrad
Copy link
Collaborator Author

conbrad commented Oct 10, 2024

ubuntu-22.04

Unintentional, I just can't read yaml. Thanks for catching.

@dgboss
Copy link
Collaborator

dgboss commented Oct 10, 2024

ubuntu-22.04

Unintentional, I just can't read yaml. Thanks for catching.

One more in that same file:

  • configure-nats-server-name

Dockerfile Show resolved Hide resolved
@conbrad conbrad requested a review from dgboss October 10, 2024 21:01
Copy link
Collaborator

@dgboss dgboss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work!

Copy link
Collaborator

@brettedw brettedw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work! And great perseverance!

warp_options = gdal.WarpOptions(
format="GTiff",
cutlineDSName=DB_READ_STRING,
cutlineSQL=f"SELECT geom FROM public.advisory_shapes WHERE id={advisory_shape_id}",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This still works?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is an unused function now. I created a ticket last week to pull out some of this unused elevation code.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh this isn't used anymore (it's from the old elevation stats job). There's a ticket to clean that up: #3997

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@conbrad conbrad requested a deployment to production October 15, 2024 17:10 Abandoned
Copy link

sonarcloud bot commented Oct 15, 2024

@conbrad conbrad temporarily deployed to production October 15, 2024 17:25 Inactive
@conbrad conbrad merged commit 1f3e00b into main Oct 15, 2024
25 checks passed
@conbrad conbrad deleted the task/bump-base-image-gdal branch October 15, 2024 17:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants