Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Morecast: Empty Cell validation" #3979

Merged
merged 1 commit into from
Oct 1, 2024

Conversation

conbrad
Copy link
Collaborator

@conbrad conbrad commented Oct 1, 2024

Copy link

sonarcloud bot commented Oct 1, 2024

Copy link

codecov bot commented Oct 1, 2024

Codecov Report

Attention: Patch coverage is 88.23529% with 2 lines in your changes missing coverage. Please review.

Project coverage is 79.92%. Comparing base (dff42b2) to head (91b16da).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
...c/features/moreCast2/components/TabbedDataGrid.tsx 33.33% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3979      +/-   ##
==========================================
- Coverage   79.98%   79.92%   -0.07%     
==========================================
  Files         302      298       -4     
  Lines       11464    11430      -34     
  Branches      549      541       -8     
==========================================
- Hits         9170     9135      -35     
  Misses       2109     2109              
- Partials      185      186       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@conbrad conbrad temporarily deployed to production October 1, 2024 17:54 Inactive
@conbrad conbrad merged commit 5467101 into main Oct 1, 2024
25 checks passed
@conbrad conbrad deleted the revert-3957-task/empty-cell-validation-morecast branch October 1, 2024 18:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants