-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update redux and redux toolkit #3976
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3976 +/- ##
=======================================
Coverage 79.98% 79.98%
=======================================
Files 302 302
Lines 11464 11464
Branches 549 549
=======================================
Hits 9170 9170
Misses 2109 2109
Partials 185 185 ☔ View full report in Codecov by Sentry. |
"api/*": ["./src/api/*"], | ||
"features/*": ["./src/features/*"], | ||
"components/*": ["src/components/*"], | ||
"components": ["./src/components/index"], |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
prettier did this. i could undo it suppose. there's a npm format command but i don't think it's part of ci or anything. is that on purpose?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah we'll have to align that in our lint check perhaps, but we don't want any code changes during CI. We most likely haven't touched this file since prettier has updated so these changes are fine.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work, thank you!
"api/*": ["./src/api/*"], | ||
"features/*": ["./src/features/*"], | ||
"components/*": ["src/components/*"], | ||
"components": ["./src/components/index"], |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah we'll have to align that in our lint check perhaps, but we don't want any code changes during CI. We most likely haven't touched this file since prettier has updated so these changes are fine.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @jmetev1!
Quality Gate passedIssues Measures |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! Thank you!
closes #3287
This updates redux and redux toolkit and makes a few small changes required for that update.
Test Links:
Landing Page
MoreCast
Percentile Calculator
C-Haines
FireBat
FireBat bookmark
Auto Spatial Advisory (ASA)
HFI Calculator