Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update redux and redux toolkit #3976

Merged
merged 4 commits into from
Oct 1, 2024
Merged

update redux and redux toolkit #3976

merged 4 commits into from
Oct 1, 2024

Conversation

jmetev1
Copy link
Collaborator

@jmetev1 jmetev1 commented Sep 28, 2024

closes #3287
This updates redux and redux toolkit and makes a few small changes required for that update.

Test Links:

Landing Page
MoreCast
Percentile Calculator
C-Haines
FireBat
FireBat bookmark
Auto Spatial Advisory (ASA)
HFI Calculator

Copy link

codecov bot commented Sep 28, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 79.98%. Comparing base (afb7524) to head (65d9e3d).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3976   +/-   ##
=======================================
  Coverage   79.98%   79.98%           
=======================================
  Files         302      302           
  Lines       11464    11464           
  Branches      549      549           
=======================================
  Hits         9170     9170           
  Misses       2109     2109           
  Partials      185      185           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

"api/*": ["./src/api/*"],
"features/*": ["./src/features/*"],
"components/*": ["src/components/*"],
"components": ["./src/components/index"],
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

prettier did this. i could undo it suppose. there's a npm format command but i don't think it's part of ci or anything. is that on purpose?

Copy link
Collaborator

@conbrad conbrad Oct 1, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah we'll have to align that in our lint check perhaps, but we don't want any code changes during CI. We most likely haven't touched this file since prettier has updated so these changes are fine.

Copy link
Collaborator

@conbrad conbrad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work, thank you!

"api/*": ["./src/api/*"],
"features/*": ["./src/features/*"],
"components/*": ["src/components/*"],
"components": ["./src/components/index"],
Copy link
Collaborator

@conbrad conbrad Oct 1, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah we'll have to align that in our lint check perhaps, but we don't want any code changes during CI. We most likely haven't touched this file since prettier has updated so these changes are fine.

Copy link
Collaborator

@brettedw brettedw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @jmetev1!

Copy link

sonarcloud bot commented Oct 1, 2024

Copy link
Collaborator

@dgboss dgboss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Thank you!

@conbrad conbrad temporarily deployed to production October 1, 2024 15:46 Inactive
@conbrad conbrad merged commit 6aff457 into main Oct 1, 2024
25 checks passed
@conbrad conbrad deleted the task/update-redux branch October 1, 2024 15:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update Redux/ReduxToolkit
4 participants