Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DeploymentConfig to Deployment #3935

Merged
merged 31 commits into from
Sep 25, 2024
Merged

DeploymentConfig to Deployment #3935

merged 31 commits into from
Sep 25, 2024

Conversation

brettedw
Copy link
Collaborator

@brettedw brettedw commented Sep 16, 2024

  • Convert all DeploymentConfigs to Deployments
  • Changes deploy bash script
    • Several of the commands previously used don't work with deployments
    • bash script is far more simple now and I believe functions similarly. Major change being rollouts now happen due to image changes or config changes
  • Adds triggers to deployments. Now whenever the api or web image changes, it will trigger a new rollout
  • Redis DC also converted to Deployment, still needs to be manually deployed
  • Also changes ZAP check to the correct URL
  • Closes DeploymentConfig's are deprecated #3873

Test Links:

Landing Page
MoreCast
Percentile Calculator
C-Haines
FireBat
FireBat bookmark
Auto Spatial Advisory (ASA)
HFI Calculator

- name: wps-redis-data
emptyDir: {}
containers:
- name: redis

Check warning

Code scanning / SonarCloud

Storage limits should be enforced

<!--SONAR_ISSUE_KEY:AZH8kXrM6XidRrsF3BmK-->Specify a storage limit for this container. <p>See more on <a href="https://sonarcloud.io/project/issues?id=bcgov_wps&issues=AZH8kXrM6XidRrsF3BmK&open=AZH8kXrM6XidRrsF3BmK&pullRequest=3935">SonarCloud</a></p>
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think I took care of this but the warning is being persistent

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perhaps it wants CPU request/limit as well?

Copy link

codecov bot commented Sep 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.34%. Comparing base (c2df18c) to head (4c728de).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3935   +/-   ##
=======================================
  Coverage   81.34%   81.34%           
=======================================
  Files         298      298           
  Lines       11423    11423           
  Branches      541      541           
=======================================
  Hits         9292     9292           
  Misses       2096     2096           
  Partials       35       35           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@brettedw brettedw closed this Sep 16, 2024
@brettedw brettedw reopened this Sep 16, 2024
@brettedw brettedw closed this Sep 17, 2024
@brettedw brettedw reopened this Sep 23, 2024
@brettedw brettedw closed this Sep 23, 2024
@brettedw brettedw reopened this Sep 23, 2024
Copy link

sonarcloud bot commented Sep 23, 2024

@brettedw brettedw marked this pull request as ready for review September 24, 2024 00:55
Copy link
Collaborator

@conbrad conbrad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work!

Copy link
Collaborator

@dgboss dgboss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work!

Copy link

sonarcloud bot commented Sep 25, 2024

@brettedw brettedw temporarily deployed to production September 25, 2024 16:49 Inactive
@brettedw brettedw merged commit 61ccde9 into main Sep 25, 2024
25 checks passed
@brettedw brettedw deleted the task/dc-to-deploy branch September 25, 2024 17:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

DeploymentConfig's are deprecated
3 participants