Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ASA - Critical Hours Frontend #3909

Merged
merged 50 commits into from
Sep 10, 2024
Merged

ASA - Critical Hours Frontend #3909

merged 50 commits into from
Sep 10, 2024

Conversation

conbrad
Copy link
Collaborator

@conbrad conbrad commented Sep 9, 2024

Test Links:

Landing Page
MoreCast
Percentile Calculator
C-Haines
FireBat
FireBat bookmark
Auto Spatial Advisory (ASA)
HFI Calculator

Copy link

codecov bot commented Sep 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.26%. Comparing base (19346ec) to head (79e4d29).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3909      +/-   ##
==========================================
+ Coverage   81.07%   81.26%   +0.19%     
==========================================
  Files         294      294              
  Lines       11386    11361      -25     
  Branches      526      526              
==========================================
+ Hits         9231     9233       +2     
+ Misses       2121     2094      -27     
  Partials       34       34              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

web/src/api/fbaAPI.ts Outdated Show resolved Hide resolved
@conbrad conbrad marked this pull request as ready for review September 10, 2024 20:59
@@ -36,7 +36,7 @@ const columns: GridColDef[] = [
{
field: 'code',
headerClassName: 'fuel-summary-header',
headerName: 'Fuel Type',
headerName: 'Primary Fuels',
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changed this back to 'Fuel Type' after stand up chat this morning

@brettedw
Copy link
Collaborator

My local db has fuel stats, but no critical hours data (table exists though). I figured it should show me the fuel data with an empty critical hours column but the API returns empty for all stats in each zone so it displays 'No fuel type information available.'
Haven't figured out why that is yet

@@ -0,0 +1,18 @@
import { Typography } from '@mui/material'
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like this file is formatted with 4 spaces for indents isntead of 2.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reran prettier on this file in: 6a2c057

We should get it configured to run on save

@conbrad
Copy link
Collaborator Author

conbrad commented Sep 10, 2024

My local db has fuel stats, but no critical hours data (table exists though). I figured it should show me the fuel data with an empty critical hours column but the API returns empty for all stats in each zone so it displays 'No fuel type information available.' Haven't figured out why that is yet

It was because it was doing an inner join and ignored results that didn't have all fuel stats and critical hours. I adjusted the query, types and tests to perform an outer join so rows with some fuel stats or some critical hours would return values in this commit: 8484b9b

@conbrad conbrad requested a review from dgboss September 10, 2024 21:57
Copy link
Collaborator

@brettedw brettedw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work. Love the endpoint & variable name simplification

Copy link

sonarcloud bot commented Sep 10, 2024

Copy link
Collaborator

@dgboss dgboss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

@conbrad conbrad temporarily deployed to production September 10, 2024 22:50 Inactive
@conbrad conbrad merged commit 65f48a9 into main Sep 10, 2024
28 checks passed
@conbrad conbrad deleted the task/critical-hours-frontend-3 branch September 10, 2024 23:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ASA: Display critical hours for fuel types (front-end)
3 participants