-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ASA - Critical Hours Frontend #3909
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3909 +/- ##
==========================================
+ Coverage 81.07% 81.26% +0.19%
==========================================
Files 294 294
Lines 11386 11361 -25
Branches 526 526
==========================================
+ Hits 9231 9233 +2
+ Misses 2121 2094 -27
Partials 34 34 ☔ View full report in Codecov by Sentry. |
@@ -36,7 +36,7 @@ const columns: GridColDef[] = [ | |||
{ | |||
field: 'code', | |||
headerClassName: 'fuel-summary-header', | |||
headerName: 'Fuel Type', | |||
headerName: 'Primary Fuels', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changed this back to 'Fuel Type' after stand up chat this morning
My local db has fuel stats, but no critical hours data (table exists though). I figured it should show me the fuel data with an empty critical hours column but the API returns empty for all stats in each zone so it displays 'No fuel type information available.' |
@@ -0,0 +1,18 @@ | |||
import { Typography } from '@mui/material' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like this file is formatted with 4 spaces for indents isntead of 2.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reran prettier on this file in: 6a2c057
We should get it configured to run on save
It was because it was doing an inner join and ignored results that didn't have all fuel stats and critical hours. I adjusted the query, types and tests to perform an outer join so rows with some fuel stats or some critical hours would return values in this commit: 8484b9b |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work. Love the endpoint & variable name simplification
Quality Gate passedIssues Measures |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great!
Test Links:
Landing Page
MoreCast
Percentile Calculator
C-Haines
FireBat
FireBat bookmark
Auto Spatial Advisory (ASA)
HFI Calculator