-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Task/use backend morecast token #3824
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think a few more changes are required on the front-end. I believe wf1AuthenticationSlice.ts
can go along with its tests. We can also remove references to the selector from TabbedDataGrid.tsx
and rootReducer.ts
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great!
Quality Gate passedIssues Measures |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3824 +/- ##
==========================================
- Coverage 79.37% 79.35% -0.03%
==========================================
Files 297 295 -2
Lines 10908 10862 -46
Branches 525 518 -7
==========================================
- Hits 8658 8619 -39
+ Misses 2105 2099 -6
+ Partials 145 144 -1 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work, thanks for tackling that so quickly
Suspect IssuesThis pull request was deployed and Sentry observed the following issues:
Did you find this useful? React with a 👍 or 👎 |
Use our API token with forecast write permissions for morecast forecast posts. Removes frontend WF1 auth wrapper.
Use our API token with forecast write permissions for morecast forecast posts. Removes frontend WF1 auth wrapper.
Use our API token with forecast write permissions for morecast forecast posts. Removes frontend WF1 auth wrapper.
Closes #3802
Test Links:
Landing Page
MoreCast
Percentile Calculator
C-Haines
FireBat
FireBat bookmark
Auto Spatial Advisory (ASA)
HFI Calculator