Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix datetime comparison check to be tz aware #3811

Closed
wants to merge 1 commit into from

Conversation

conbrad
Copy link
Collaborator

@conbrad conbrad commented Jul 30, 2024

Consumers were logging errors: TypeError: can't compare offset-naive and offset-aware datetimes

Test Links:

Landing Page
MoreCast
Percentile Calculator
C-Haines
FireBat
FireBat bookmark
Auto Spatial Advisory (ASA)
HFI Calculator

Copy link

sonarcloud bot commented Jul 30, 2024

Copy link

codecov bot commented Jul 30, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 79.35%. Comparing base (1f7854e) to head (4b022ca).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3811   +/-   ##
=======================================
  Coverage   79.35%   79.35%           
=======================================
  Files         297      297           
  Lines       10886    10886           
  Branches      525      525           
=======================================
  Hits         8639     8639           
  Misses       2102     2102           
  Partials      145      145           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@conbrad conbrad closed this Jul 30, 2024
@conbrad conbrad temporarily deployed to production July 30, 2024 17:03 Inactive
@conbrad conbrad deleted the task/fix-snow-processing-time-check branch July 30, 2024 17:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant