Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RDPS precip output #3810

Merged
merged 17 commits into from
Aug 2, 2024
Merged

RDPS precip output #3810

merged 17 commits into from
Aug 2, 2024

Conversation

brettedw
Copy link
Collaborator

@brettedw brettedw commented Jul 30, 2024

Splits out function for creating the output 24hr accumlated RDPS precip key from the logic of getting keys to diff.

WeatherModelKeyParams will be used to get RDPS keys for various weather parameters in #3775

Test Links:

Landing Page
MoreCast
Percentile Calculator
C-Haines
FireBat
FireBat bookmark
Auto Spatial Advisory (ASA)
HFI Calculator

@brettedw brettedw closed this Jul 30, 2024
@brettedw brettedw reopened this Jul 30, 2024
@brettedw brettedw closed this Jul 30, 2024
@brettedw brettedw reopened this Jul 30, 2024
Copy link

codecov bot commented Jul 30, 2024

Codecov Report

Attention: Patch coverage is 73.91304% with 12 lines in your changes missing coverage. Please review.

Project coverage is 79.37%. Comparing base (a5a2685) to head (a88b2e9).

Files Patch % Lines
api/app/jobs/rdps_sfms.py 0.00% 6 Missing ⚠️
api/app/weather_models/precip_rdps_model.py 60.00% 6 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3810      +/-   ##
==========================================
+ Coverage   79.35%   79.37%   +0.01%     
==========================================
  Files         297      297              
  Lines       10886    10908      +22     
  Branches      525      525              
==========================================
+ Hits         8639     8658      +19     
- Misses       2102     2105       +3     
  Partials      145      145              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@brettedw brettedw marked this pull request as ready for review July 30, 2024 17:40
Copy link
Collaborator

@conbrad conbrad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good!

@brettedw brettedw requested review from conbrad and dgboss August 1, 2024 16:36
Copy link
Collaborator

@conbrad conbrad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work, just a minor naming comment

api/app/weather_models/precip_rdps_model.py Outdated Show resolved Hide resolved
Copy link
Collaborator

@dgboss dgboss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Strong work!

Copy link

sonarcloud bot commented Aug 2, 2024

@brettedw brettedw temporarily deployed to production August 2, 2024 16:14 Inactive
@brettedw brettedw merged commit e83dd6e into main Aug 2, 2024
29 checks passed
@brettedw brettedw deleted the task/rdps-24hr-precip-output branch August 2, 2024 16:27
dgboss pushed a commit that referenced this pull request Aug 14, 2024
- Changes file naming convention for output 24 hour precip
- Extends calculation of precip to 36 hours from model run time
vanislekahuna pushed a commit to vanislekahuna/wps that referenced this pull request Sep 19, 2024
- Changes file naming convention for output 24 hour precip
- Extends calculation of precip to 36 hours from model run time
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants