-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
RDPS precip output #3810
RDPS precip output #3810
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3810 +/- ##
==========================================
+ Coverage 79.35% 79.37% +0.01%
==========================================
Files 297 297
Lines 10886 10908 +22
Branches 525 525
==========================================
+ Hits 8639 8658 +19
- Misses 2102 2105 +3
Partials 145 145 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work, just a minor naming comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Strong work!
36 hours Co-authored-by: dgboss <[email protected]>
Quality Gate passedIssues Measures |
- Changes file naming convention for output 24 hour precip - Extends calculation of precip to 36 hours from model run time
- Changes file naming convention for output 24 hour precip - Extends calculation of precip to 36 hours from model run time
Splits out function for creating the output 24hr accumlated RDPS precip key from the logic of getting keys to diff.
WeatherModelKeyParams
will be used to get RDPS keys for various weather parameters in #3775Test Links:
Landing Page
MoreCast
Percentile Calculator
C-Haines
FireBat
FireBat bookmark
Auto Spatial Advisory (ASA)
HFI Calculator