Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Store snow masked hfi rasters #3807

Closed
wants to merge 4 commits into from
Closed

Conversation

conbrad
Copy link
Collaborator

@conbrad conbrad commented Jul 29, 2024

Store the intermediate raster that's snow masked, not just the ultimate pmtiles vector. This allows us to simplify some of the TPI elevation processing in #3696

Note: formatting changes caused by ruff on save

Test Links:

Landing Page
MoreCast
Percentile Calculator
C-Haines
FireBat
FireBat bookmark
Auto Spatial Advisory (ASA)
HFI Calculator

@conbrad conbrad requested review from dgboss and brettedw July 29, 2024 21:27
# We need a geojson file to pass to tippecanoe
temp_geojson = write_geojson(layer, temp_dir)

pmtiles_filename = f'hfi{for_date.strftime("%Y%m%d")}.pmtiles'
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we use the get_pmtiles_filename() function from hfi_filepath.py?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oops thanks, done in 878183e

Copy link

sonarcloud bot commented Jul 29, 2024

Copy link
Collaborator

@dgboss dgboss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@conbrad conbrad closed this Jul 29, 2024
@conbrad conbrad temporarily deployed to production July 29, 2024 22:19 Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants