Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Task/upgrade yarn #3791

Merged
merged 19 commits into from
Jul 22, 2024
Merged

Task/upgrade yarn #3791

merged 19 commits into from
Jul 22, 2024

Conversation

jmetev1
Copy link
Collaborator

@jmetev1 jmetev1 commented Jul 19, 2024

  1. upgrades yarn.
    i've been working on this for a while so not positive what will be required when others work in web/.
    Running yarn install might work. or may have to first do corepack enable yarn set version berry
    current npmrc might work. or might have to do
 yarn config set npmScopes.psu.npmRegistryServer https://artifacts.developer.gov.bc.ca/artifactory/api/npm/pe1e-psu-npm-local/
 yarn config set npmScopes.psu.npmAlwaysAuth true 
 yarn config set npmScopes.psu.npmAuthToken ${ARTIFACTORY_SVCACCT_TOKEN}
  1. reorders dockerfile.web steps for better caching

Test Links:

Landing Page
MoreCast
Percentile Calculator
C-Haines
FireBat
FireBat bookmark
Auto Spatial Advisory (ASA)
HFI Calculator
closes #1296

Dockerfile.web Show resolved Hide resolved
Copy link

codecov bot commented Jul 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 79.36%. Comparing base (5a1775d) to head (105bc80).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3791      +/-   ##
==========================================
- Coverage   79.39%   79.36%   -0.03%     
==========================================
  Files         297      297              
  Lines       10882    10882              
  Branches      525      525              
==========================================
- Hits         8640     8637       -3     
- Misses       2097     2100       +3     
  Partials      145      145              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jmetev1 jmetev1 requested review from dgboss and conbrad July 19, 2024 14:16
@conbrad conbrad requested a review from brettedw July 19, 2024 15:26
Dockerfile.web Outdated Show resolved Hide resolved
Copy link

sonarcloud bot commented Jul 19, 2024

Copy link
Collaborator

@dgboss dgboss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Thank you!

@dgboss dgboss temporarily deployed to production July 22, 2024 16:40 Inactive
@dgboss dgboss merged commit eef2619 into main Jul 22, 2024
29 checks passed
@dgboss dgboss deleted the task/upgrade-yarn branch July 22, 2024 18:36
vanislekahuna pushed a commit to vanislekahuna/wps that referenced this pull request Sep 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Upgrade Yarn to version 2
4 participants