Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make model filtering more obvious #3771

Merged
merged 3 commits into from
Jul 10, 2024
Merged

Make model filtering more obvious #3771

merged 3 commits into from
Jul 10, 2024

Conversation

dgboss
Copy link
Collaborator

@dgboss dgboss commented Jul 9, 2024

  • change to the PlaylistAdd button
  • make the column header text a button
  • make Forecast column header clickable

Test Links:

Landing Page
MoreCast
Percentile Calculator
C-Haines
FireBat
FireBat bookmark
Auto Spatial Advisory (ASA)
HFI Calculator

Copy link

codecov bot commented Jul 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 79.66%. Comparing base (e841364) to head (2a855d1).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3771   +/-   ##
=======================================
  Coverage   79.66%   79.66%           
=======================================
  Files         297      297           
  Lines       10823    10823           
  Branches      525      525           
=======================================
  Hits         8622     8622           
  Misses       2056     2056           
  Partials      145      145           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@brettedw brettedw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

Copy link

sonarcloud bot commented Jul 10, 2024

@dgboss dgboss temporarily deployed to production July 10, 2024 19:18 Inactive
@dgboss dgboss merged commit 1d036f6 into main Jul 10, 2024
29 checks passed
@dgboss dgboss deleted the task/model-dropdown-vis/3633 branch July 10, 2024 19:42
vanislekahuna pushed a commit to vanislekahuna/wps that referenced this pull request Sep 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants