Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hook up 24 precip tiff rolling computations #3762

Merged
merged 37 commits into from
Jul 16, 2024
Merged

Conversation

conbrad
Copy link
Collaborator

@conbrad conbrad commented Jul 3, 2024

  • Hooks up the 24 hour accumulating precip raster calculations as part of the RDPS job.
  • Uses the start datetime of the job (now in UTC) as the seed.
  • Decided to start by storing every computed tif in s3 for now to be able to inspect intermediate results in dev if need be, this can be changed to use memory only later (using the same keys as keys in a hashmap).
  • Closes SFMS: Precip model inputs for weather calculations #3682

Test Links:

Landing Page
MoreCast
Percentile Calculator
C-Haines
FireBat
FireBat bookmark
Auto Spatial Advisory (ASA)
HFI Calculator

@conbrad conbrad requested review from dgboss and brettedw July 3, 2024 22:15
Copy link

codecov bot commented Jul 3, 2024

Codecov Report

Attention: Patch coverage is 39.36170% with 57 lines in your changes missing coverage. Please review.

Project coverage is 79.39%. Comparing base (a4694cf) to head (e7d4265).

Files Patch % Lines
api/app/weather_models/precip_rdps_model.py 35.55% 29 Missing ⚠️
api/app/utils/s3.py 26.66% 22 Missing ⚠️
api/app/jobs/rdps_sfms.py 0.00% 6 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3762      +/-   ##
==========================================
- Coverage   79.66%   79.39%   -0.27%     
==========================================
  Files         297      297              
  Lines       10823    10882      +59     
  Branches      525      525              
==========================================
+ Hits         8622     8640      +18     
- Misses       2056     2097      +41     
  Partials      145      145              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

api/app/jobs/rdps_sfms.py Outdated Show resolved Hide resolved
api/app/weather_models/precip_rdps_model.py Outdated Show resolved Hide resolved
api/app/jobs/rdps_sfms.py Show resolved Hide resolved
Copy link
Collaborator

@brettedw brettedw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

Copy link

sonarcloud bot commented Jul 15, 2024

@conbrad conbrad temporarily deployed to production July 16, 2024 16:25 Inactive
@conbrad conbrad merged commit 43572d7 into main Jul 16, 2024
29 checks passed
@conbrad conbrad deleted the task/hook-up-24-precip-tiff branch July 16, 2024 16:38
vanislekahuna pushed a commit to vanislekahuna/wps that referenced this pull request Sep 19, 2024
- Hooks up the 24 hour accumulating precip raster calculations as part of the RDPS job.
- Uses the start datetime of the job (now in UTC) as the seed.
- Decided to start by storing every computed tif in s3 for now to be able to inspect intermediate results in dev if need be, this can be changed to use memory only later (using the same keys as keys in a hashmap).
- Closes bcgov#3682
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

SFMS: Precip model inputs for weather calculations
3 participants