-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Set up sentry hook #3569
Set up sentry hook #3569
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3569 +/- ##
==========================================
- Coverage 80.45% 80.41% -0.05%
==========================================
Files 288 289 +1
Lines 10372 10381 +9
Branches 507 508 +1
==========================================
+ Hits 8345 8348 +3
- Misses 1885 1891 +6
Partials 142 142 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! Just a couple questions/nits:
- Are the values for sentry_dsn for the front end and back end supposed to be different? The secret for the API is different than the value in the configmap for the front-end.
- Does the sentry_dsn for the API need to be in a secret (or would a config map do)? I'm just curious, it doesn't matter to me!
- Maybe consider updating the API's .env.example file as a reminder of the new env variable.
Nice work!
Yep, we configure a project for the frontend and backend separately and it looks like sentry seperates dsn by project
I think a secret would be best, otherwise if leaked we could get stack traces from other codebases
Will do, good call! |
Cool, thanks for the info! |
Quality Gate passedIssues Measures |
Test Links:
Landing Page
MoreCast
Percentile Calculator
MoreCast
C-Haines
FireBat
FireBat bookmark
Auto Spatial Advisory (ASA)
HFI Calculator