Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set up sentry hook #3569

Merged
merged 19 commits into from
Apr 29, 2024
Merged

Set up sentry hook #3569

merged 19 commits into from
Apr 29, 2024

Conversation

conbrad
Copy link
Collaborator

@conbrad conbrad commented Apr 29, 2024

  • Doesn't add feedback form just captures errors and replays
  • Enabled for backend as well

Test Links:

Landing Page
MoreCast
Percentile Calculator
MoreCast
C-Haines
FireBat
FireBat bookmark
Auto Spatial Advisory (ASA)
HFI Calculator

Copy link

codecov bot commented Apr 29, 2024

Codecov Report

Attention: Patch coverage is 33.33333% with 6 lines in your changes are missing coverage. Please review.

Project coverage is 80.41%. Comparing base (3b7eca3) to head (ff6bcff).

Files Patch % Lines
web/src/components/FeedbackButton.tsx 0.00% 6 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3569      +/-   ##
==========================================
- Coverage   80.45%   80.41%   -0.05%     
==========================================
  Files         288      289       +1     
  Lines       10372    10381       +9     
  Branches      507      508       +1     
==========================================
+ Hits         8345     8348       +3     
- Misses       1885     1891       +6     
  Partials      142      142              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@conbrad conbrad requested a review from dgboss April 29, 2024 18:29
Copy link
Collaborator

@dgboss dgboss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Just a couple questions/nits:

  1. Are the values for sentry_dsn for the front end and back end supposed to be different? The secret for the API is different than the value in the configmap for the front-end.
  2. Does the sentry_dsn for the API need to be in a secret (or would a config map do)? I'm just curious, it doesn't matter to me!
  3. Maybe consider updating the API's .env.example file as a reminder of the new env variable.
    Nice work!

@conbrad
Copy link
Collaborator Author

conbrad commented Apr 29, 2024

  1. Are the values for sentry_dsn for the front end and back end supposed to be different? The secret for the API is different than the value in the configmap for the front-end.

Yep, we configure a project for the frontend and backend separately and it looks like sentry seperates dsn by project

  1. Does the sentry_dsn for the API need to be in a secret (or would a config map do)? I'm just curious, it doesn't matter to me!

I think a secret would be best, otherwise if leaked we could get stack traces from other codebases

  1. Maybe consider updating the API's .env.example file as a reminder of the new env variable.

Will do, good call!

@dgboss
Copy link
Collaborator

dgboss commented Apr 29, 2024

Cool, thanks for the info!

Copy link

sonarcloud bot commented Apr 29, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@conbrad conbrad temporarily deployed to production April 29, 2024 20:57 Inactive
@conbrad conbrad merged commit cbc7f63 into main Apr 29, 2024
28 checks passed
@conbrad conbrad deleted the task/set-up-sentry-no-feedback branch April 29, 2024 21:12
vanislekahuna pushed a commit to vanislekahuna/wps that referenced this pull request Sep 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants