Limit hourlies endpoint to only store ffmc files #3563
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3563 +/- ##
=======================================
Coverage 80.45% 80.45%
=======================================
Files 288 288
Lines 10370 10371 +1
Branches 507 507
=======================================
+ Hits 8343 8344 +1
Misses 1885 1885
Partials 142 142 ☔ View full report in Codecov by Sentry. |
dgboss
approved these changes
Apr 25, 2024
| 'Create-time': datetime.now().isoformat()}) | ||
| # We should get a 200 response if the file is uploaded successfully. | ||
| assert response.status_code == 200 | ||
| # We should have called put_object once. |
There was a problem hiding this comment.
Comment should say put_object shouldn't be called.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Test Links:
Landing Page
MoreCast
Percentile Calculator
MoreCast
C-Haines
FireBat
FireBat bookmark
Auto Spatial Advisory (ASA)
HFI Calculator