Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove HFI role checks #3549

Merged
merged 8 commits into from
Apr 19, 2024
Merged

Remove HFI role checks #3549

merged 8 commits into from
Apr 19, 2024

Conversation

dgboss
Copy link
Collaborator

@dgboss dgboss commented Apr 18, 2024

Backend

  • Remove checks for specific roles (except station admin role) but maintain need for authentication

Frontend

  • Hide signin/signout button
  • Comment out use of roles (except for station admin)

Test Links:

Landing Page
MoreCast
Percentile Calculator
MoreCast
C-Haines
FireBat
FireBat bookmark
Auto Spatial Advisory (ASA)
HFI Calculator

@dgboss dgboss requested a review from brettedw April 18, 2024 23:19
@codecov-commenter
Copy link

codecov-commenter commented Apr 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 80.43%. Comparing base (2657d91) to head (6a350ed).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3549      +/-   ##
==========================================
- Coverage   80.47%   80.43%   -0.04%     
==========================================
  Files         289      288       -1     
  Lines       10374    10358      -16     
  Branches      514      507       -7     
==========================================
- Hits         8348     8331      -17     
- Misses       1884     1885       +1     
  Partials      142      142              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

sonarcloud bot commented Apr 19, 2024

Quality Gate Passed Quality Gate passed

Issues
1 New issue
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@conbrad conbrad temporarily deployed to production April 19, 2024 17:25 Inactive
@conbrad conbrad merged commit 097f009 into main Apr 19, 2024
24 checks passed
@conbrad conbrad deleted the task/hfi-calc-access/3523 branch April 19, 2024 17:42
vanislekahuna pushed a commit to vanislekahuna/wps that referenced this pull request Sep 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants