Bumps pgbouncer version to 1.21.0 that includes support for prepared statements #3539
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…statement caching at the protocol level
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3539 +/- ##
=======================================
Coverage 80.46% 80.46%
=======================================
Files 289 289
Lines 10376 10376
Branches 514 514
=======================================
Hits 8349 8349
Misses 1885 1885
Partials 142 142 ☔ View full report in Codecov by Sentry. |
|
brettedw
approved these changes
Apr 15, 2024
dgboss
approved these changes
Apr 15, 2024
vanislekahuna
pushed a commit
to vanislekahuna/wps
that referenced
this pull request
Sep 19, 2024
…statements (bcgov#3539) We started getting errors about asyncpg prepared statements like: `prepared statement "__asyncpg_stmt2_" already exists` Turns out pre version 1.21.0, `pgbouncer` didn't support caching prepared statements. According to the discussion here, `sqlalchemy`/`asyncpg` has no support for turning off prepared statements: sqlalchemy/sqlalchemy#6467 This PR pulls in the `pgbouncer` version 1.21.0 for supporting an LRU cache of prepared statements across transactions. More background information here: - https://www.crunchydata.com/blog/prepared-statements-in-transaction-mode-for-pgbouncer - https://www.pgbouncer.org/config.html#max_prepared_statements
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We started getting errors about asyncpg prepared statements like:
prepared statement "__asyncpg_stmt2_" already existsTurns out pre version 1.21.0,
pgbouncerdidn't support caching prepared statements.According to the discussion here,
sqlalchemy/asyncpghas no support for turning off prepared statements: sqlalchemy/sqlalchemy#6467This PR pulls in the
pgbouncerversion 1.21.0 for supporting an LRU cache of prepared statements across transactions.More background information here:
Test Links:
Landing Page
MoreCast
Percentile Calculator
MoreCast
C-Haines
FireBat
FireBat bookmark
Auto Spatial Advisory (ASA)
HFI Calculator